Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing configure excludes button presents another configure excludes button #21215

Closed
Tyriar opened this issue Feb 22, 2017 · 10 comments
Closed
Assignees
Labels
feature-request Request for new features or functionality javascript JavaScript support issues typescript Typescript support issues ux User experience issues verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 22, 2017

#21037

Pressing this:

image

Presents:

image

I've already committed to configuring them, why do I need to press it twice?

@Tyriar Tyriar added javascript JavaScript support issues typescript Typescript support issues ux User experience issues labels Feb 22, 2017
@mjbvz mjbvz added this to the March 2017 milestone Feb 23, 2017
@mjbvz
Copy link
Contributor

mjbvz commented Feb 23, 2017

This is not a regression. This has been the flow for a while now but should be improved. Moving to March

@mjbvz mjbvz modified the milestones: March 2017, April 2017 Mar 22, 2017
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug *as-designed Described behavior is as designed feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Apr 20, 2017
@mjbvz
Copy link
Contributor

mjbvz commented Apr 20, 2017

After looking through this again, I believe the intention behind this design was to show the user more information about the error and what they need to do. Hovering over the status bar item to find out the details was not very discoverable.

I'm unsure what a good alternative approach would be here. If we just open the tsconfig.json and don't display any message when a user clicks on this item status bar, it may not be clear to the user what they need to do. My vote would be to try to open the tsconfig if it exists and also display a error/message inside of it indicating what to fix

@Tyriar
Copy link
Member Author

Tyriar commented Apr 21, 2017

My vote would be to try to open the tsconfig if it exists and also display a error/message inside of it indicating what to fix

That might be better.

@mjbvz mjbvz modified the milestones: April 2017, May 2017 Apr 24, 2017
@mjbvz mjbvz modified the milestones: June 2017, May 2017 May 26, 2017
@mjbvz mjbvz closed this as completed in a5c9a7c Jun 7, 2017
@roblourens roblourens added verification-needed Verification of issue is requested and removed *as-designed Described behavior is as designed labels Jun 27, 2017
@roblourens
Copy link
Member

How do I get that "configure excludes" message to show up? Is it only for very large workspaces?

@mjbvz
Copy link
Contributor

mjbvz commented Jun 28, 2017

Yes, try creating a jsconfig.json that includes node_modules for a large project. A config file like this should do it:

{
    "exclude": []
}

@roblourens
Copy link
Member

Shouldn't it open the jsconfig if that exists? Now it only shows the message and doesn't open the jsconfig.

@mjbvz
Copy link
Contributor

mjbvz commented Jun 28, 2017

Sorry, I didn't specify the expected behavior very well here. Opening the jsconfig automatically was a pretty annoying experience, so now, when the configure excludes is triggered, you should see a warning message about this. Clicking the warning message should open the jsconfig

@roblourens
Copy link
Member

You're describing the opposite of what I thought - that previously you have to click twice to get to the jsconfig, and that now it should open the jsconfig automatically after the first click.

That's what I see in stable (I click the status bar, then click the button in the message bar). In Insiders, I click the status bar then see it open a warning message with no button to open the jsconfig.

@mjbvz
Copy link
Contributor

mjbvz commented Jun 28, 2017

Yes you are correct. This is not doing the correct thing when you click on the status bar. It should try to open the config file if one exists

@mjbvz mjbvz added the verification-found Issue verification failed label Jun 28, 2017
@mjbvz mjbvz reopened this Jun 28, 2017
@mjbvz mjbvz modified the milestones: July 2017, June 2017 Jun 29, 2017
@mjbvz
Copy link
Contributor

mjbvz commented Jun 29, 2017

Moving to july as I want more expose in insiders and the issue is not very high priority

@mjbvz mjbvz closed this as completed in 1b39981 Aug 2, 2017
@rebornix rebornix added verified Verification succeeded and removed verification-found Issue verification failed verification-needed Verification of issue is requested labels Aug 4, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality javascript JavaScript support issues typescript Typescript support issues ux User experience issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants