-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimap lacks separation from editor #21229
Comments
@alexandrudima am I doing something wrong, for me I see no separation to the minimap: This is running "out of sources". |
The shadow is dropped when there is a horizontal scrollbar and the scrollLeft is not at its maximum position. Exactly how the top shadow works (the top shadow drops when there is a vertical scrollbar and the scrollLeft is not at its minimum position) i.e. make a line long enough that it is wider than the viewport. |
@alexandrudima oh I see, I somehow thought this would mean to add a general separation from the editor. E.g. I think it still looks a bit weird in this case where the viewzone just stops: The scrollbar to the right for example has a very visible border. |
Yeah, that looks slightly weird. I wonder why the tree is not in the same dark blue shade. Perhaps that would help. i.e. on the left hand side it doesn't feel weird. @jrieken I would love a UX designer input here ... |
Unsure how the color have been defined. I think someone aligned with the explorer... UX input please. Tho it might make sense to always show the drop shadow? |
Or maybe start to draw a border if and only if a viewzone is there? |
Let's track in #21359. This issue solves the problem for the text overflowing case, but not the embedded editors case. |
Because their backgrounds are the same, it sometimes looks like a line is much shorter than it actually is below the minimap's colored content. E.g., line 123:
A simple fix might be to end the minimap where its content ends.
The text was updated successfully, but these errors were encountered: