Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimap lacks separation from editor #21229

Closed
chrmarti opened this issue Feb 22, 2017 · 9 comments
Closed

Minimap lacks separation from editor #21229

chrmarti opened this issue Feb 22, 2017 · 9 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-minimap Code/Text minimap widget issues verified Verification succeeded
Milestone

Comments

@chrmarti
Copy link
Contributor

  • VSCode Version: Code - Insiders 1.10.0-insider (256d76f, 2017-02-22T07:04:54.544Z)
  • OS Version: Darwin x64 15.6.0
  • Extensions:
Extension Author Version
EditorConfig EditorConfig 0.3.4
autofilename JerryHong 0.1.3
vscode-simple-icons LaurentTreguier 0.10.0
vscode-docker PeterJausovec 0.0.11
azure-cli chrmarti 0.3.0
regex chrmarti 0.0.7
vscode-eslint dbaeumer 1.2.5
ghlink dt 0.0.5
tslint eg2 0.8.1
vscode-scss mrmlnc 0.6.1
PowerShell ms-vscode 0.9.0
cpptools ms-vscode 0.10.0
debugger-for-chrome msjsdiag 2.5.2
diff rafaelmaiolla 0.0.1
vscode-open-in-github sysoev 1.3.1

Because their backgrounds are the same, it sometimes looks like a line is much shorter than it actually is below the minimap's colored content. E.g., line 123:
screen shot 2017-02-22 at 3 04 03 pm

A simple fix might be to end the minimap where its content ends.

@chrmarti chrmarti added bug Issue identified by VS Code Team member as probable bug editor-minimap Code/Text minimap widget issues labels Feb 22, 2017
@roblourens
Copy link
Member

Maybe related, it cuts off the special buttons in some editors, like launch.json:

image

@alexdima alexdima added this to the February 2017 milestone Feb 23, 2017
@jrieken jrieken added the verified Verification succeeded label Feb 24, 2017
@bpasero
Copy link
Member

bpasero commented Feb 24, 2017

@alexandrudima am I doing something wrong, for me I see no separation to the minimap:

image

This is running "out of sources".

@alexdima
Copy link
Member

alexdima commented Feb 24, 2017

The shadow is dropped when there is a horizontal scrollbar and the scrollLeft is not at its maximum position. Exactly how the top shadow works (the top shadow drops when there is a vertical scrollbar and the scrollLeft is not at its minimum position)

i.e. make a line long enough that it is wider than the viewport.

@bpasero
Copy link
Member

bpasero commented Feb 24, 2017

@alexandrudima oh I see, I somehow thought this would mean to add a general separation from the editor. E.g. I think it still looks a bit weird in this case where the viewzone just stops:

image

The scrollbar to the right for example has a very visible border.

@alexdima
Copy link
Member

Yeah, that looks slightly weird. I wonder why the tree is not in the same dark blue shade. Perhaps that would help. i.e. on the left hand side it doesn't feel weird. @jrieken

I would love a UX designer input here ...

@jrieken
Copy link
Member

jrieken commented Feb 24, 2017

Unsure how the color have been defined. I think someone aligned with the explorer... UX input please. Tho it might make sense to always show the drop shadow?

@alexdima
Copy link
Member

The dom arrangement of things doesn't make the shadow work either. I suggest we open a separate issue for the embedded editors case:

image

@bpasero
Copy link
Member

bpasero commented Feb 24, 2017

Or maybe start to draw a border if and only if a viewzone is there?

@alexdima
Copy link
Member

alexdima commented Feb 24, 2017

Let's track in #21359. This issue solves the problem for the text overflowing case, but not the embedded editors case.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-minimap Code/Text minimap widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants