Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leverage configurationDefaults for languages that we bundle with VS Code #21301

Closed
egamma opened this issue Feb 23, 2017 · 3 comments
Closed

Leverage configurationDefaults for languages that we bundle with VS Code #21301

egamma opened this issue Feb 23, 2017 · 3 comments
Assignees
@aeschli
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
February 2017

Comments

@egamma
Copy link
Member

egamma commented Feb 23, 2017 •
edited

Now that we support default language specific settings #19733 we should make a pass and leverage this new support for languages we bundle.

For example:

  • yaml -> TAB === 2 spaces
  • make -> Do not translate tabs to spaces
  • ...
@egamma egamma added the feature-request Request for new features or functionality label Feb 23, 2017
@egamma egamma added this to the February 2017 milestone Feb 23, 2017
@aeschli
Copy link
Contributor

aeschli commented Feb 23, 2017

I added defaults for

  • go (tabs)
  • makefile (tabs)
  • yaml (spaces, 2)

@egamma egamma added the verification-needed Verification of issue is requested label Feb 24, 2017
@egamma
Copy link
Member Author

egamma commented Feb 24, 2017

As discussed in the standup, we will also add a configuration default for Markdown (word wrap, no quick suggest)

@egamma egamma reopened this Feb 24, 2017
@aeschli
Copy link
Contributor

aeschli commented Feb 24, 2017

Fixed by 8293443

@aeschli aeschli closed this as completed Feb 24, 2017
@egamma egamma added the verified Verification succeeded label Feb 24, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
February 2017
Development

No branches or pull requests
2 participants
@egamma @aeschli