Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings editor - Put cursor at current find result #22159

Closed
roblourens opened this issue Mar 7, 2017 · 4 comments
Closed

Settings editor - Put cursor at current find result #22159

roblourens opened this issue Mar 7, 2017 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality settings-editor VS Code settings editor issues
Milestone

Comments

@roblourens
Copy link
Member

  • Open settings editor
  • cmd+f to do a search
  • Press enter to focus a search result that exists in your settings.json
  • Press cmd+1 to move focus to settings.json

The cursor should be at the current highlighted search result, but instead it's just at its previous location.

@d-akara
Copy link

d-akara commented Mar 7, 2017

@roblourens how about just using cursor down to move focus to settings.json.
This would be similar to how the global file search allows you to press down cursor to move to the results from the search box.
Also, if the default were 'cmd+1' I would lose the ability to jump back to the first editor group if I open the settings in a different group.

@roblourens
Copy link
Member Author

I think using the arrow key could work too, that's a good point.

I say 'cmd+1' here as the usual 'focus first editor group'. If you open the settings in the second editor group, you can use 'cmd+2' for it, and get back to the first group with cmd+1. I don't know how discoverable that is either, since in my scenario, focus is already in the first group, so would it occur to people to use it to focus the editor?

@sandy081 sandy081 added the settings-editor VS Code settings editor issues label Mar 8, 2017
@sandy081 sandy081 added this to the Backlog milestone Mar 8, 2017
@sandy081
Copy link
Member

sandy081 commented Mar 8, 2017

Good thoughts.. will think about the key for focussing the editor.

@sandy081
Copy link
Member

down already focuses into the editable settings editor.

Added support to position the cursor to currently focussed / matched setting.

To Verify:

  • Open settings editor
  • cmd+f to do a search
  • Press enter to focus a search result that exists in your settings.json
  • Press down and settings.json is focussed and the cursor is placed at the currently focussed matching setting

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality settings-editor VS Code settings editor issues
Projects
None yet
Development

No branches or pull requests

3 participants