Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partially Broken Complex Script Rendering of Tamil #22352

Closed
ThirumalaiK opened this issue Mar 10, 2017 · 6 comments
Closed

Partially Broken Complex Script Rendering of Tamil #22352

ThirumalaiK opened this issue Mar 10, 2017 · 6 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug editor-rendering Editor rendering issues verified Verification succeeded
Milestone
April 2018

Comments

@ThirumalaiK
Copy link

  • VSCode Version: Code 1.10.2 (8076a19, 2017-03-08T13:56:35.908Z)
  • OS Version: Darwin x64 16.4.0
  • Extensions:
Extension Author Version
xml DotJoshJohnson 1.7.0

Steps to Reproduce:

  1. Editing an xml file which contains tamil translated strings
    2.Whenever I open rendering or some letters are always broken at random points every time. But the same letter is rendered properly on other locations in the same file. Just look at the last word of line no 146. (Left: Brackets - Right: Visual Studio Code). As I said the position of broken text changes on every launch.

screen shot 2017-03-10 at 10 02 19 am

Original File:
strings (1).xml.zip
@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Apr 19, 2017
@alexdima alexdima self-assigned this Oct 26, 2017
@ThirumalaiK ThirumalaiK mentioned this issue Mar 30, 2018
Closed
@alexdima alexdima added editor-rendering Editor rendering issues and removed editor labels Apr 4, 2018
@alexdima
Copy link
Member

alexdima commented Apr 4, 2018 •
edited

We are breaking up the text into multiple <span> elements approx. every 50 characters. We probably shouldn't do it in this case.

Reduced repro:

  • open a new untitled file:
JoyShareல் பின்தொடர்ந்து, விடீயோ, ஜோக்குகள், அனிமேசன், நகைச்சுவை படங்கள் மற்றும் செய்திகளை பெறுவீர்

Type spaces at the beginning of the line:

kapture 2018-04-04 at 11 44 34

@alexdima
Copy link
Member

alexdima commented Apr 4, 2018

Another repro (from #42700):

वो ऐसा क्या है जो हमारे अंदर भी है और बाहर भी है। जिसकी वजह से हम सब हैं। जिसने इस सृष्टि की रचना की है।

@alexdima
Copy link
Member

alexdima commented Apr 4, 2018

Another repro, using 'COMBINING ACUTE ACCENT' (U+0301):

12345689012345678901234568901234567890123456890abába

image

alexdima added a commit that referenced this issue Apr 4, 2018
@alexdima
Simplify ViewLineRenderingData (#22352)
b58f27d
alexdima added a commit that referenced this issue Apr 4, 2018
@alexdima
Add isBasicASCII to RenderLineInput (#22352)
0f436b5
@alexdima alexdima added this to the April 2018 milestone Apr 5, 2018
@roblourens
Copy link
Member

I can't repro this in 1.22.2

@roblourens roblourens added verified Verification succeeded and removed verified Verification succeeded labels Apr 24, 2018
@alexdima
Copy link
Member

alexdima commented Apr 25, 2018 •
edited

@roblourens To repro you need to have default settings. i.e. use a monospace font and not use ligatures or other extensions that introduce inline decorations.

@roblourens
Copy link
Member

roblourens commented Apr 25, 2018 •
edited

disabling ligatures was the key...

@roblourens roblourens added the verified Verification succeeded label Apr 25, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug editor-rendering Editor rendering issues verified Verification succeeded
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
5 participants
@roblourens @rebornix @alexdima @ThirumalaiK @ramya-rao-a