Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide "terminal.integrated.enableBold" setting #22422

Closed
yustnip opened this issue Mar 10, 2017 · 20 comments · Fixed by #22465
Closed

Provide "terminal.integrated.enableBold" setting #22422

yustnip opened this issue Mar 10, 2017 · 20 comments · Fixed by #22465
Assignees
Labels
feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@yustnip
Copy link

yustnip commented Mar 10, 2017

It will be great to have a possibility to change a font weight for the integrated terminal. Now a text inside it looks bolder than a text in the editor:

screenshot from 2017-03-11 00-19-24

  • VSCode Version: 1.10.2
  • OS Version: Ubuntu 16.04
@Tyriar
Copy link
Member

Tyriar commented Mar 10, 2017

Do you mean you want to set all text in the terminal to be bold? Because that would conflict with the shell's ability to bold text itself:

image

Do you have any editor specific settings that deal with font weight?

@Tyriar Tyriar added terminal Integrated terminal issues info-needed Issue requires more information from poster labels Mar 10, 2017
@yustnip
Copy link
Author

yustnip commented Mar 10, 2017

Do you mean you want to set all text in the terminal to be bold?
Yes, for example, to set all text in the terminal as "normal", "bold", etc.

VS Code terminal (different font weight):
screenshot from 2017-03-11 00-51-45

Ubuntu terminal (same font weight):
screenshot from 2017-03-11 00-52-15

Do you have any editor specific settings that deal with font weight?
No, for the editor in VS Code I have default font weight settings.

@Tyriar
Copy link
Member

Tyriar commented Mar 10, 2017

Do you have this set in gnome-terminal?

image

@yustnip
Copy link
Author

yustnip commented Mar 10, 2017

No, I have it is disabled now. With "Allow bold text" checkmark a font weight behavior is the same as in VS Code terminal.

@Tyriar
Copy link
Member

Tyriar commented Mar 10, 2017

Ok, makes sense 😄

@Tyriar Tyriar changed the title Provide "terminal.integrated.fontWeight" setting Provide "terminal.integrated.enableBold" setting Mar 10, 2017
@Tyriar Tyriar added good first issue Issues identified as good for first-time contributors feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities and removed info-needed Issue requires more information from poster labels Mar 10, 2017
@Tyriar Tyriar self-assigned this Mar 10, 2017
@Tyriar
Copy link
Member

Tyriar commented Mar 10, 2017

Accepting PRs on this, you will need to:

  • Add the setting to terminal.contribution.ts
  • Add the setting to the terminal.ts config interface
  • Set some class on .integrated-terminal.panel based on the setting
  • Add CSS for the class in xterm.css

@lifez
Copy link
Contributor

lifez commented Mar 11, 2017

@Tyriar @yustnip I would take this PR. Can I ?

@Tyriar
Copy link
Member

Tyriar commented Mar 12, 2017

@lifez that would be awesome 😃

@lifez
Copy link
Contributor

lifez commented Mar 12, 2017

Great I will do this PR :)

@lifez
Copy link
Contributor

lifez commented Mar 12, 2017

I've implemented the terminal setting on the PR #22465 , it'd be nice to get some comments on it :)

Tyriar added a commit that referenced this issue Mar 20, 2017
Provide "terminal.integrated.enableBold" setting connected to #22422
@Tyriar Tyriar closed this as completed Mar 20, 2017
@Tyriar Tyriar added this to the March 2017 milestone Mar 20, 2017
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Mar 24, 2017
@michelkaporin
Copy link
Contributor

Cannot verify, as I don't see a difference between "terminal.integrated.enableBold": true and false on Windows cmd and powershell integrated terminals in VS Code v1.11.0.

@isidorn
Copy link
Contributor

isidorn commented Mar 29, 2017

I also do not see the difference on my osx zsh shell,
Reopening this issue. I propose to either make it work on all platforms or to remove this setting or at the very least document that it only works on linux.

@isidorn isidorn reopened this Mar 29, 2017
@Tyriar
Copy link
Member

Tyriar commented Mar 29, 2017

@michelkaporin I don't think bold is used on cmd or PS unless you use a custom prompt?

@isidorn I expect it to work fine on all platforms, it depends on whether your shell outputs bold. Could you try again by running the following and comparing the styles?

echo -e '\x1b[1mFOO\x1b[0mFOO'

image

They should look the same when the setting it true:

image

@Tyriar Tyriar closed this as completed Mar 29, 2017
@Tyriar Tyriar added verification-needed Verification of issue is requested and removed verification-needed Verification of issue is requested labels Mar 29, 2017
@michelkaporin
Copy link
Contributor

@Tyriar If this setting exists I would expect it to work on all terminals as @isidorn mentioned. A workaround would be to make description to point out which terminals are supported.
E.g. default Windows cmd supports bolding, although this setting is not working for it.

P.S. you've pinged a different person (it happens most people confuse my nickname with michaelchiche, poor guy gets many notifications that are addressed to me 😃).

@isidorn
Copy link
Contributor

isidorn commented Mar 30, 2017

@Tyriar for me they are the same in both cases (setting false and setting true). However if I run the command in my iTerm i nicely get the output bolded

screen shot 2017-03-30 at 10 36 43

screen shot 2017-03-30 at 10 36 32

@Tyriar
Copy link
Member

Tyriar commented Mar 30, 2017

@isidorn does the font you use in the terminal not have a bold variant maybe? It doesn't look like the top screenshot has any bold text.

@michelkaporin all terminals that can output bold text are supported. If enableBold is true and bold text is showing up, flipping it to false should make the text non-bold. Maybe allowBold would be more fitting for what it is doing?

@isidorn
Copy link
Contributor

isidorn commented Mar 30, 2017

@Tyriar I am not using any special font in the terminal, not sure if it supports bold. Inspecint it in chrome dev it is the usual font-family: Menlo, Monaco, 'Courier New', monospace;

P.S aren't you sleeping 😁

@michelkaporin
Copy link
Contributor

@Tyriar I would stick to enableBold but changing the description of the setting.

all terminals that can output bold text are supported

As I've said bolding in cmd.exe terminal does not work for me.

@Tyriar
Copy link
Member

Tyriar commented Mar 30, 2017

@isidorn my sleep was a bit funky yesterday 😛. One way to test whether the font supports bold is to manually add font-weight:bold to the element in devtools.

@Tyriar
Copy link
Member

Tyriar commented Mar 30, 2017

@michaelchiche 👍 deferred to April as it's the end of endgame #23694

Tyriar added a commit that referenced this issue Mar 31, 2017
@Tyriar Tyriar added the verified Verification succeeded label Apr 26, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants