-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide "terminal.integrated.enableBold" setting #22422
Comments
No, I have it is disabled now. With "Allow bold text" checkmark a font weight behavior is the same as in VS Code terminal. |
Ok, makes sense 😄 |
Accepting PRs on this, you will need to:
|
@lifez that would be awesome 😃 |
Great I will do this PR :) |
I've implemented the terminal setting on the PR #22465 , it'd be nice to get some comments on it :) |
Provide "terminal.integrated.enableBold" setting connected to #22422
Cannot verify, as I don't see a difference between "terminal.integrated.enableBold": true and false on Windows cmd and powershell integrated terminals in VS Code v1.11.0. |
I also do not see the difference on my osx zsh shell, |
@michelkaporin I don't think bold is used on cmd or PS unless you use a custom prompt? @isidorn I expect it to work fine on all platforms, it depends on whether your shell outputs bold. Could you try again by running the following and comparing the styles? echo -e '\x1b[1mFOO\x1b[0mFOO' They should look the same when the setting it true: |
@Tyriar If this setting exists I would expect it to work on all terminals as @isidorn mentioned. A workaround would be to make description to point out which terminals are supported. P.S. you've pinged a different person (it happens most people confuse my nickname with michaelchiche, poor guy gets many notifications that are addressed to me 😃). |
@Tyriar for me they are the same in both cases (setting false and setting true). However if I run the command in my iTerm i nicely get the output bolded |
@isidorn does the font you use in the terminal not have a bold variant maybe? It doesn't look like the top screenshot has any bold text. @michelkaporin all terminals that can output bold text are supported. If |
@Tyriar I am not using any special font in the terminal, not sure if it supports bold. Inspecint it in chrome dev it is the usual font-family: Menlo, Monaco, 'Courier New', monospace; P.S aren't you sleeping 😁 |
@Tyriar I would stick to
As I've said bolding in cmd.exe terminal does not work for me. |
@isidorn my sleep was a bit funky yesterday 😛. One way to test whether the font supports bold is to manually add |
@michaelchiche 👍 deferred to April as it's the end of endgame #23694 |
It will be great to have a possibility to change a font weight for the integrated terminal. Now a text inside it looks bolder than a text in the editor:
The text was updated successfully, but these errors were encountered: