Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Toggle MiniMap to View Menu #22423

Closed
seanmcbreen opened this issue Mar 10, 2017 · 5 comments
Closed

Add Toggle MiniMap to View Menu #22423

seanmcbreen opened this issue Mar 10, 2017 · 5 comments
Assignees
Labels
editor-minimap Code/Text minimap widget issues feature-request Request for new features or functionality on-testplan
Milestone

Comments

@seanmcbreen
Copy link

We should add a toggle here for discover-ability.

@ilyabirman
Copy link

I’d also want a command for key binding.

@alexdima alexdima added editor-minimap Code/Text minimap widget issues feature-request Request for new features or functionality labels Mar 27, 2017
@alexdima alexdima added this to the Backlog milestone Mar 27, 2017
@seanmcbreen
Copy link
Author

image

@alexdima
Copy link
Member

alexdima commented Jun 9, 2017

@seanmcbreen

  • Adding a toggle that writes to user settings and enables/disables the minimap for all editors is easy. Such a toggle fits in with our settings story.
  • Adding a toggle that enables/disables the minimap for the current file (similar to toggle word wrap) is ridiculous hard due to our settings story, which does not have this concept. For the toggle word wrap we need to maintain an in-memory file-based dictionary and work around the entire workbench settings story. We need to spy on when the workbench applies the settings coming in from our configuration service, and immediately undo the incoming settings, such that we establish the desirable toggle in all cases. Here are some of the ridiculous high amount of bugs that we had when the toggle tried to use the settings story. And here is the controller that constantly spies on all editors to undo the incoming settings. I suggest we plan for this and involve @sandy081 and @bpasero such that the configuration service is enhanced with per-file settings such that I don't need to write another one of those for the next file-level toggle we want to have.

Which type of toggle do you have in mind when you say "We should add a toggle"

@summivox
Copy link

Adding a toggle that enables/disables the minimap for the current file (similar to toggle word wrap) is ridiculous hard due to our settings story, which does not have this concept

Such an oversight, considering that vim has had set vs setl for ages.

@alexdima alexdima modified the milestones: August 2017, Backlog Aug 25, 2017
@alexdima
Copy link
Member

I went with the easy implementation that writes to user settings.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-minimap Code/Text minimap widget issues feature-request Request for new features or functionality on-testplan
Projects
None yet
Development

No branches or pull requests

4 participants