Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance tests inside unit tests? #22512

Closed
bpasero opened this issue Mar 13, 2017 · 2 comments
Closed

Performance tests inside unit tests? #22512

bpasero opened this issue Mar 13, 2017 · 2 comments
Assignees
@roblourens @chrmarti
Labels
debt Code quality issues
Milestone
March 2017

Comments

@bpasero
Copy link
Member

bpasero commented Mar 13, 2017

I see that we run a textsearch performance test and quickopen performance test as part of our unit tests. Do we really need to run those everytime? I think we should extract them towards code-performance-test.sh or similar to keep our unit tests execute fast.
@bpasero bpasero added the debt Code quality issues label Mar 13, 2017
@roblourens
Copy link
Member

They don't actually run (they can't, they don't have the test workspace to run on). We could run them via a separate script though.

@chrmarti
Copy link
Contributor

They are run in a way they doesn't use much time. Running them makes sure they don't break.

@chrmarti chrmarti added this to the March 2017 milestone Mar 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@roblourens
Reinstate textsearch perf test as integration test -
a1f0ded 
- fix its flakiness
- add test-int-mocha so .integrationTest.js files can be run separately from code.sh integration tests.
- make all.js support globs with --run
- Fix microsoft#22512
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@roblourens
Reinstate textsearch perf test as integration test -
c7cf86e 
- fix its flakiness
- add test-int-mocha so .integrationTest.js files can be run separately from code.sh integration tests.
- make all.js support globs with --run
- Fix microsoft#22512
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@chrmarti chrmarti

Labels
debt Code quality issues
Projects
None yet
Milestone
March 2017
Development

No branches or pull requests
3 participants
@roblourens @bpasero @chrmarti