Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl+A in git side bar should select all files #22769

Closed
Deilan opened this issue Mar 17, 2017 · 6 comments
Closed

Ctrl+A in git side bar should select all files #22769

Deilan opened this issue Mar 17, 2017 · 6 comments
Assignees
@joaomoreno
Labels
feature-request Request for new features or functionality git GIT issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities verification-needed Verification of issue is requested verified Verification succeeded
Milestone
January 2018

Comments

@Deilan
Copy link

Deilan commented Mar 17, 2017 •
edited

Ctrl+A keyboard shortcut on focused git side bar should select all files in it. That's pretty much it. :)
@joaomoreno joaomoreno added this to the Backlog milestone Mar 20, 2017
@joaomoreno joaomoreno added feature-request Request for new features or functionality git GIT issues labels Mar 20, 2017
@joaomoreno joaomoreno removed their assignment Apr 25, 2017
@joaomoreno joaomoreno added good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities labels Apr 25, 2017
Lixire added a commit that referenced this issue May 18, 2017
@Lixire
Add feature from #22769
aa508f1 
- `Ctrl+A` now selects all files when focused on the scm viewlet
@acarrab
Copy link

acarrab commented Jul 30, 2017

Hey guys, I am a new almost contributor so this looks like a good story to get my feet wet with. I will pick up this one if that is okay

@joaomoreno joaomoreno assigned Lixire and unassigned Lixire Aug 8, 2017
@Lixire
Copy link
Contributor

Lixire commented Aug 8, 2017

@acarrab Are you still up for this?

@acarrab
Copy link

acarrab commented Aug 9, 2017

Hey sorry it has been a busy week. Honestly, I have been focusing on reading through a lot of the code that there is in my free time. I don't know if I should have asked for a task if I had not read through some of that stuff yet. So pretty much you could take it if you like :), but if not I should get to it soon. I don't mind finding other tasks though as well

@JamesEarle
Copy link

@acarrab if you don't want this I'd like to try it. I'm also a new contributor looking to get started with the VS Code codebase. @Lixire any suggestions where to begin / what files are relevant?

@Lixire
Copy link
Contributor

Lixire commented Aug 23, 2017

@JamesEarle You should start off looking at the scmViewlet.ts file. The viewlet is defined there and the command should be provided by it. More information about how the command should behave is here: #26843 .

@Lixire Lixire removed their assignment Aug 24, 2017
@Deilan Deilan changed the title [Feature Request] Ctrl+A in git side bar should select all files Ctrl+A in git side bar should select all files Sep 6, 2017
@novak novak mentioned this issue Oct 4, 2017
Closed
tvand7093 added a commit to tvand7093/vscode that referenced this issue Oct 14, 2017
@tvand7093
Enabled keyboard control to list to fix microsoft#22769
520b1a5
@tvand7093 tvand7093 mentioned this issue Oct 14, 2017
Closed
@joaomoreno joaomoreno self-assigned this Dec 11, 2017
@joaomoreno joaomoreno modified the milestones: Backlog, November 2017, December 2017 Dec 11, 2017
@joaomoreno joaomoreno added the verification-needed Verification of issue is requested label Dec 15, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 25, 2018
@sandy081
Copy link
Member

sandy081 commented Jan 30, 2018 •
edited

@joaomoreno Select all is also selecting the group header

image

Also there is no way to unselect. Expected esc should unselect (#42511)

@chrmarti chrmarti added the verified Verification succeeded label Feb 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
feature-request Request for new features or functionality git GIT issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

Successfully merging a pull request may close this issue.

Added support for selecting all files in git list tvand7093/vscode
7 participants
@joaomoreno @Deilan @JamesEarle @acarrab @chrmarti @sandy081 @Lixire