Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider fullwidth characters when rendering tabs #22832

Closed
amos402 opened this issue Mar 18, 2017 · 4 comments
Closed

Consider fullwidth characters when rendering tabs #22832

amos402 opened this issue Mar 18, 2017 · 4 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug editor-rendering Editor rendering issues verified Verification succeeded
Milestone
February 2018

Comments

@amos402
Copy link

amos402 commented Mar 18, 2017

  • VSCode Version:1.10
  • OS Version:Windows 10 1607

In vscode, one fullwidth character take one col, so the code is not aligned when import some from the other editors.

Steps to Reproduce:

Examle text

asd = "擦擦擦"		#asd
asd = "あああ"		#asd
asd = "aaa"		#asd

in vscode

_20170319_015945

_20170319_015956

in vs

_20170319_021129

The character count is not equal with the column count
@alexdima
Copy link
Member

Font rendering is handled by Electron/Chromium. If you'd like to get a wide char rendered with the width of 2 chars, I can recommend trying different fonts. e.g. Inconsolata.

@alexdima alexdima added font-rendering Font rendering issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) electron Issues and items related to Electron labels Mar 27, 2017
@alexdima alexdima added this to the Backlog milestone Mar 27, 2017
@alexdima alexdima added the feature-request Request for new features or functionality label Mar 27, 2017
@amos402
Copy link
Author

amos402 commented Mar 27, 2017

No matter what font used, this problem still exist. The reason they didn't align is not the font, is about the element layout of the editor, you can see the example text will work correctly in other browsers or editors.

@alexdima alexdima changed the title The method of calculate the fullwidth characters is not friendly Consider fullwidth characters when rendering tabs Mar 27, 2017
@alexdima alexdima added editor-core Editor basic functionality and removed electron Issues and items related to Electron font-rendering Font rendering issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Mar 27, 2017
@alexdima
Copy link
Member

alexdima commented Mar 27, 2017 •
edited

👍 I understand now what you refer to, I thought it was about the width of the CJK characters, but it's about the width of tabs following CJK chars.

@alexdima alexdima mentioned this issue Mar 28, 2017
Closed
@yh1224 yh1224 mentioned this issue Feb 23, 2018
Merged
@alexdima alexdima added editor-rendering Editor rendering issues bug Issue identified by VS Code Team member as probable bug and removed editor-core Editor basic functionality feature-request Request for new features or functionality labels Mar 1, 2018
@alexdima alexdima modified the milestones: Backlog, February 2018 Mar 1, 2018
@alexdima alexdima mentioned this issue Mar 1, 2018
Closed
@alexdima
Copy link
Member

alexdima commented Mar 1, 2018

To the verifier, please use a font where a wide character is painted with the width of 2 latin characters, such as e.g. Inconsolata:

asd = "擦"		#asd
asd = "あ"		#asd
asd = "a"		#asd

Before:
image

After:
image

@joaomoreno joaomoreno added the verified Verification succeeded label Mar 2, 2018
This was referenced Mar 5, 2018
Closed
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug editor-rendering Editor rendering issues verified Verification succeeded
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
3 participants
@joaomoreno @amos402 @alexdima