Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings provides examples that use single quotes for properties, even though property keys must be doublequoted #22920

Closed
HowardWolosky opened this issue Mar 20, 2017 · 0 comments
Closed

Settings provides examples that use single quotes for properties, even though property keys must be doublequoted #22920

HowardWolosky opened this issue Mar 20, 2017 · 0 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
March 2017

Comments

@HowardWolosky
Copy link
Member

  • VSCode Version: 1.10.2
  • OS Version: Windows 10.0.15063

Steps to Reproduce:

  1. File -> Preferences -> Settings
  2. Type in extension to filter the options
  3. Observe the comment above "files.associations": {}:

// Configure file associations to languages (e.g. '*.extension': 'html'). These have precedence over the default associations of the languages installed.

  1. If you try to do that exact example '*.extension': 'html' you get an error saying that Property keys must be doublequoted

Suggested fix:

Update the comments associated with any setting that has an example to ensure that the example uses double-quotes for the property keys.
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Mar 23, 2017
@bpasero bpasero added this to the March 2017 milestone Mar 23, 2017
@sandy081 sandy081 added the verified Verification succeeded label Mar 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
March 2017
Development

No branches or pull requests
3 participants
@bpasero @sandy081 @HowardWolosky