Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e.charCodeAt is not a function #22928

Closed
vscodeerrors opened this issue Mar 21, 2017 · 3 comments
Closed

e.charCodeAt is not a function #22928

vscodeerrors opened this issue Mar 21, 2017 · 3 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
March 2017

Comments

@vscodeerrors
Copy link

Issue Id: 4afee445-750c-8d3f-b441-a72bfe0473fb

Versions
- 1.10.2
Stack
TypeError: e.charCodeAt is not a function
/vs/base/common/strings.ts#L333:18 (charCodeAt)
/vs/editor/contrib/suggest/common/suggest.ts#L155:8 (compareIgnoreCase)
/vs/editor/contrib/suggest/common/suggest.ts#L189:8 (defaultComparator)
at Array.sort (native)
/vs/editor/contrib/suggest/common/suggest.ts#L106:60 (sort)
vs/workbench/electron-browser/vs/base/common/winjs.base.raw.js#L1170:0 (onComplete)
vs/workbench/electron-browser/vs/base/common/winjs.base.raw.js#L852:0 (_notify)
vs/workbench/electron-browser/vs/base/common/winjs.base.raw.js#L1068:0 (enter)
vs/workbench/electron-browser/vs/base/common/winjs.base.raw.js#L1036:0 (_run)
vs/workbench/electron-browser/vs/base/common/winjs.base.raw.js#L1566:0 (onComplete)
@alexdima alexdima assigned jrieken and unassigned alexdima Mar 27, 2017
@jrieken jrieken added this to the March 2017 milestone Mar 27, 2017
@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Mar 27, 2017
@jrieken
Copy link
Member

jrieken commented Mar 27, 2017

hm. Can only be from snippets or debug...

@jrieken
Copy link
Member

jrieken commented Mar 29, 2017 •
edited

@isidorn Looking at all implementors of ISuggestion#label I believe only debug is left as a candidate of returning suggestions without a label...

@isidorn
Copy link
Contributor

isidorn commented Mar 29, 2017

Since we can not control what debug extensions return I have simply introduced a null guard to not allow suggestions without a label

@jrieken jrieken added the verified Verification succeeded label Mar 30, 2017
@jrieken jrieken removed their assignment Mar 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
March 2017
Development

No branches or pull requests
4 participants
@jrieken @isidorn @alexdima @vscodeerrors