Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken syntax highlighting in JavaScript template strings with 'Light' or 'Dark' themes #23111

Closed
marktitorenkov opened this issue Mar 23, 2017 · 2 comments · Fixed by #23115
Closed

Broken syntax highlighting in JavaScript template strings with 'Light' or 'Dark' themes #23111

marktitorenkov opened this issue Mar 23, 2017 · 2 comments · Fixed by #23115
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues languages-basic Basic language support issues typescript Typescript support issues verified Verification succeeded
Milestone
March 2017

Comments

@marktitorenkov
Copy link

marktitorenkov commented Mar 23, 2017 •
edited

  • VSCode Version: Code 1.10.2 (8076a19, 2017-03-08T14:02:52.799Z)
  • OS Version: Windows_NT ia32 10.0.14393
  • Extensions:
Extension Author Version
vs-keybindings ms-vscode 0.1.3

In JavaScript, when using template strings like this:

`My name is ${name}`

the variable 'name' is the same color as the rest of the string instead of white. This is only present when using 'Light' and 'Dark' themes and not in 'Light+' and 'Dark+'.
image
@mjbvz mjbvz self-assigned this Mar 23, 2017
mjbvz added a commit to mjbvz/vscode that referenced this issue Mar 23, 2017
@mjbvz
Improve coloring of js template strings Fixes microsoft#23111
f565eb5
@mjbvz mjbvz added javascript JavaScript support issues languages-basic Basic language support issues typescript Typescript support issues labels Mar 23, 2017
@mjbvz mjbvz mentioned this issue Mar 23, 2017
Merged
@mjbvz mjbvz added this to the March 2017 milestone Mar 23, 2017
@mjbvz mjbvz added the verification-needed Verification of issue is requested label Mar 23, 2017
mjbvz added a commit that referenced this issue Mar 23, 2017
@mjbvz
Improve coloring of js template strings Fixes #23111 (#23115)
076d135
@mjbvz
Copy link
Contributor

mjbvz commented Mar 23, 2017

Thanks for the report. The bug here seems to be that the ${ and } were not highlighted in JS. The new colorization for the plain light/dark themes should now look like this:

screen shot 2017-03-23 at 1 39 22 pm

@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug and removed verification-needed Verification of issue is requested labels Mar 28, 2017
@jrieken
Copy link
Member

jrieken commented Mar 28, 2017

@mjbvz please don't the verification-needed label for bugs, but the bug-label which also "triggers" verification but after testing new things

@jrieken jrieken added the verified Verification succeeded label Mar 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues languages-basic Basic language support issues typescript Typescript support issues verified Verification succeeded
Projects
None yet
Milestone
March 2017
Development

Successfully merging a pull request may close this issue.

Improve coloring of js template strings mjbvz/vscode
3 participants
@jrieken @mjbvz @marktitorenkov