Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Implementations Code lens For TS < 2.2.1 #23120

Closed
mjbvz opened this issue Mar 23, 2017 · 4 comments
Closed

Disable Implementations Code lens For TS < 2.2.1 #23120

mjbvz opened this issue Mar 23, 2017 · 4 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues verified Verification succeeded
Milestone
March 2017

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Mar 23, 2017

The results of implementations from TSServer is not reliable in versions of TS prior to 2.2.1. We should disable the implementations code lens in those cases as well, just like we disable the go to implementation provider
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues labels Mar 23, 2017
@mjbvz mjbvz added this to the March 2017 milestone Mar 23, 2017
@mjbvz mjbvz self-assigned this Mar 23, 2017
@mjbvz mjbvz closed this as completed in cd896ba Mar 23, 2017
@michelkaporin
Copy link
Contributor

michelkaporin commented Mar 30, 2017 •
edited

Cannot verify, implementations code lens is still appearing for me, I've installed TS 2.1.4 globally and checked for the lense and it still appears. I am missing something?

@roblourens
Copy link
Member

@michelkaporin I can verify, 2.1.4 is > 2.1.1 :)

@roblourens roblourens added the verified Verification succeeded label Mar 31, 2017
@michelkaporin
Copy link
Contributor

@roblourens Hmm..., I thought prior to 2.2.1, not 2.1.1.

@roblourens
Copy link
Member

I completely misread that... sorry @michelkaporin...

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues verified Verification succeeded
Projects
None yet
Milestone
March 2017
Development

No branches or pull requests
3 participants
@roblourens @michelkaporin @mjbvz