-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't use "open loaded scripts" to load a URL with query params #23194
Comments
That normalize code should only be executed if the source could not be found - otherwise |
It tries to get the source from |
I don't know about replacing |
Yes, |
Also, #33712 |
I think opening the file by putting its url into a |
I've addressed this issue by making sure that the flow So if a Uri is constructed in the following way:
the debugContentProvider inside VS Code will retrieve the content by sending a "sourceRequest" with a "Source" argument to the debug adapter identified by the debug session. |
Verify that Rob's Chrome-debug case from above works. |
It is escaping the query parameter, but works anyway using the new loadedSources API, because then we can rely on sourceReference instead of a string path.
|
I have also seen this (with the Firefox debug adapter) and couldn't find any user-visibile ill effects. In particular, the source url is displayed correctly in the tab opened from the Loaded Scripts Explorer (i.e. the query parameter is unescaped there and other escaped characters in the url remain escaped). |
Added "Verified" label since both comments from above confirm that this works correctly now. |
It does rely on me updating chrome-debug, in case anybody else tries this. I'll do that this week. |
Chrome-debug supports .js files with query parameters (
http://localhost/foo.js?bar
). But if I load one with "Open loaded scripts", the query parameter is stripped. This happens here: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/debug/browser/debugContentProvider.ts#L40 since fsPath doesn't include the query parameter. Any idea how to make this work? I don't think URI is expecting to have a URL with another scheme.The text was updated successfully, but these errors were encountered: