Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git gutter indicators doesn't work in a network folder #23297

Closed
deejaybill opened this issue Mar 27, 2017 · 8 comments
Closed

Git gutter indicators doesn't work in a network folder #23297

deejaybill opened this issue Mar 27, 2017 · 8 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues important Issue identified as high-priority verified Verification succeeded
Milestone
March Recovery 20...

Comments

@deejaybill
Copy link

  • VSCode Version: Code 1.10.2 (8076a19, 2017-03-08T14:02:52.799Z)
  • OS Version: Windows_NT ia32 10.0.14393
  • Extensions: none

Steps to Reproduce:

  1. Install the latest git-scm version (2.12.1)
  2. Create or clone a git repository
  3. Make a first commit
  4. Try to edit the code again
  5. Gutter indicators (red triangle, green and blue bar) doesn't show

The same folder works fine with atom editor. The Viewing Diffs works well just the gutter indicator doesn't work also in a fresh installation of Visual Studio Code and Git-scm.
@frame
Copy link

frame commented Mar 27, 2017

Are you using a network folder for your project? I noticed the git gutter only works with local files.

@deejaybill
Copy link
Author

Yes, I'm using a network folder. I will try with a local folder as soon as possible.
Atom editor works fine with a network folder so I don't think it is a problem of Git-scm.

@joaomoreno joaomoreno added this to the Backlog milestone Mar 28, 2017
@joaomoreno joaomoreno changed the title Gutter indicators doesn't work Git gutter indicators doesn't work in a network folder Mar 28, 2017
@joaomoreno
Copy link
Member

What type of network folder? A Windows network share?

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug git GIT issues labels Mar 28, 2017
@deejaybill
Copy link
Author

I've just made some tests:

  • Local folder works fine
  • Windows network share folder doesn't work
  • A connection to a network folder with Map Network Wizard works fine

@koodinorja
Copy link

I believe I had similar issue. I have windows 10 and i have virtual box that is running ubuntu virtual machine, all my projects are in the virtual machine.

When I map network drive everything works fine.

When i add network location, i get problems with paths.

Source control tab shows the files that have been modified and the paths for them.
\\192.168.56.101\sharedfolder\project\some-file.ts
git output gives this message when viewing modified file
fatal: Path 'C:/sharedfolder/project/some-file.ts' does not exist (neither on disk nor in the index).

@joaomoreno
Copy link
Member

Thanks for the details.

@joaomoreno joaomoreno mentioned this issue Apr 6, 2017
Closed
@joaomoreno joaomoreno added the important Issue identified as high-priority label Apr 7, 2017
@joaomoreno
Copy link
Member

Issue is here: https://github.com/Microsoft/vscode/blob/master/extensions/git/src/contentProvider.ts#L63

joaomoreno added a commit that referenced this issue Apr 10, 2017
@joaomoreno
🐛 use fsPath when getting paths out of URIs
c393d51 
fixes #23297
@joaomoreno
Copy link
Member

Needs one more fix for the diff editor.

@joaomoreno joaomoreno reopened this Apr 10, 2017
@joaomoreno joaomoreno mentioned this issue Apr 10, 2017
Closed
joaomoreno added a commit that referenced this issue Apr 10, 2017
@joaomoreno
🐛 isolate git uri handling
1469f4a 
fixes #23297
@isidorn isidorn added the verified Verification succeeded label Apr 12, 2017
@mkszepp mkszepp mentioned this issue Apr 14, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Milestone
March Recovery 2017 (2)
Development

No branches or pull requests
5 participants
@joaomoreno @frame @isidorn @koodinorja @deejaybill