Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relaunch terminal after shell selection on Windows #23358

Closed
alexdima opened this issue Mar 28, 2017 · 2 comments
Closed

Relaunch terminal after shell selection on Windows #23358

alexdima opened this issue Mar 28, 2017 · 2 comments
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded windows VS Code on Windows issues
Milestone
April 2017

Comments

@alexdima
Copy link
Member

alexdima commented Mar 28, 2017 •
edited

Testing #23130

(Might be caused by #23357)

  • Choose Customize from the info message

  • Choose cmd

  • The user settings are automatically changed to contain: "terminal.integrated.shell.windows": "C:\\windows\\Sysnative\\cmd.exe"

  • Observe, the integrated terminal still shows Powershell:
    image

Edit: After restarting VS Code the integrated terminal now uses cmd.exe
@alexdima alexdima changed the title Customizing terminal does not seem to work Customizing terminal does not apply until restarting VS Code Mar 28, 2017
@Tyriar
Copy link
Member

Tyriar commented Mar 28, 2017

You should be able to just relaunch the terminal, maybe that's not clear though. Perhaps I should follow up on the idea of listening for changes in the current instance, and if there aren't any after the selection it's killed and a new one is launched.

@Tyriar Tyriar added feature-request Request for new features or functionality terminal Integrated terminal issues labels Mar 28, 2017
@Tyriar Tyriar added this to the April 2017 milestone Mar 28, 2017
@Tyriar Tyriar changed the title Customizing terminal does not apply until restarting VS Code Relaunch terminal after shell selection on Windows Mar 28, 2017
@Tyriar Tyriar added the windows VS Code on Windows issues label Mar 28, 2017
Tyriar added a commit that referenced this issue Apr 3, 2017
@Tyriar
Create terminal after selecting shell on Windows
24ffb01 
This only applies to when the suggestion button is pressed. Note the old
shell remains open in the background to be safe.

Part opf #23358
@Tyriar Tyriar closed this as completed in 77030fa Apr 3, 2017
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Apr 25, 2017
@chrmarti chrmarti added the verified Verification succeeded label Apr 27, 2017
@alexdima
Copy link
Member Author

👍 also just saw it working

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Milestone
April 2017
Development

No branches or pull requests
3 participants
@Tyriar @alexdima @chrmarti