Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve keybindings search in Keyboard shortcuts Editor #23368

Closed
alexdima opened this issue Mar 28, 2017 · 0 comments
Closed

Improve keybindings search in Keyboard shortcuts Editor #23368

alexdima opened this issue Mar 28, 2017 · 0 comments
Assignees
@sandy081
Labels
feature-request Request for new features or functionality keybindings VS Code keybinding issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
April 2017

Comments

@alexdima
Copy link
Member

alexdima commented Mar 28, 2017 •
edited by sandy081

Testing #23287

  • searching for ctrl+k should be the same as searching for control+k
  • same for cmd on OSX
  • Highlight rendered keybindings those got matched (symbols or text) instead of appending text (ARIA Label) for matches
@sandy081 sandy081 added the keybindings VS Code keybinding issues label Mar 28, 2017
@sandy081 sandy081 added this to the March 2017 milestone Mar 28, 2017
@sandy081 sandy081 mentioned this issue Mar 29, 2017
Closed
@sandy081 sandy081 modified the milestones: April 2017, March 2017 Mar 29, 2017
@sandy081 sandy081 added the feature-request Request for new features or functionality label Apr 4, 2017
@sandy081 sandy081 changed the title Searching for ctrl should be the same as searching for control Improve keybindings search in Keyboard shortcuts Editor Apr 4, 2017
@sandy081 sandy081 added the verification-needed Verification of issue is requested label Apr 4, 2017
sandy081 added a commit that referenced this issue Apr 4, 2017
@sandy081
#23368 - Improve keybinding search
905710b 
- Implement APIs in ResolvedKeybinding to expose parts
- Implement APIs in ResolvedKeybinding to get labels without modifiers
- Adopt tests to above API changes
- Use above APIs to search and highlight keybindings
- A new keybinding label widget to render a keybinding
- Adopt above widget in Keyboard shortcuts editor and define keybinding widget
sandy081 added a commit that referenced this issue Apr 5, 2017
@sandy081
#23368 Improve filtering keybindings
19f3cab 
- More accurate results by detecting parts
- Support exact matches
- Support meta key
@sandy081 sandy081 closed this as completed Apr 5, 2017
@sandy081 sandy081 mentioned this issue Apr 21, 2017
Closed
@kieferrm kieferrm mentioned this issue Apr 25, 2017
Closed
15 tasks
@sandy081 sandy081 mentioned this issue Apr 25, 2017
Closed
@jrieken jrieken added the verified Verification succeeded label Apr 26, 2017
@sandy081 sandy081 mentioned this issue Apr 28, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
feature-request Request for new features or functionality keybindings VS Code keybinding issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
April 2017
Development

No branches or pull requests
3 participants
@jrieken @alexdima @sandy081