Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase search result limit #23431

Closed
joaomoreno opened this issue Mar 28, 2017 · 5 comments
Closed

Increase search result limit #23431

joaomoreno opened this issue Mar 28, 2017 · 5 comments
Assignees
@roblourens
Milestone
April 2017

Comments

@joaomoreno
Copy link
Member

Testing #23319

When searching for a in vscode, results are capped at around 2500. Surely we can pump that up quite a bit, now that we have a super awesome searcher.

image
@joaomoreno
Copy link
Member Author

Actually, when configuring useRipgrep = false, I get almost double the amount:

image

@roblourens
Copy link
Member

The limit is 2048 + whatever it finds in open files, so you might have had more files open the second time.

@roblourens roblourens added this to the April 2017 milestone Mar 28, 2017
@roblourens
Copy link
Member

The limit is now 10000. Nothing is on fire yet. Here's to seeing that irritating yellow popup less often!

@ToMakeSense
Copy link

@roblourens any place to config this limit(search results have a limit of 10000 items)?

@ToMakeSense
Copy link

ToMakeSense commented Jul 19, 2017 •
edited

@roblourens Oh, I see Bump up max search result limit, Unfortunately, It's not an item in Settings!

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
None yet
Projects
None yet
Milestone
April 2017
Development

No branches or pull requests
3 participants
@joaomoreno @roblourens @ToMakeSense