Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to assign a keybinding #23593

Closed
seanmcbreen opened this issue Mar 29, 2017 · 5 comments
Closed

Unable to assign a keybinding #23593

seanmcbreen opened this issue Mar 29, 2017 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues verified Verification succeeded
Milestone

Comments

@seanmcbreen
Copy link

Testing #23287

I'm unable to assign a binding to this command:

image

I have the sublime keymap installed and and empty keybindings.json
image

Sean

@seanmcbreen seanmcbreen added the bug Issue identified by VS Code Team member as probable bug label Mar 29, 2017
@sandy081
Copy link
Member

@seanmcbreen Not sure how you got this empty keybindings file. By default you should have an empty array in the file. Can you please try having an empty array in the file, save it and try?

I think this is due to the empty file.

@sandy081 sandy081 added the keybindings VS Code keybinding issues label Mar 29, 2017
@sandy081 sandy081 added this to the April 2017 milestone Mar 29, 2017
@egamma
Copy link
Member

egamma commented Mar 30, 2017

@sandy081 since the user can easily delete the contents of keybindings.json manually I suggest that we do some sanity checking and try to recover from an error situation like an empty file.

@sandy081
Copy link
Member

sandy081 commented Mar 30, 2017

@egamma Sure... I am doing checks in the background and bailing out if there are issues cannot be resolved. But I agree this certain case we can recover.

Moving to March to bring it for discussion to consider or not

@sandy081 sandy081 modified the milestones: March 2017, April 2017 Mar 30, 2017
@jrieken
Copy link
Member

jrieken commented Mar 30, 2017

@sandy081 I still see the error when I have an empty json-file. I don't think it's taking too much risk just optimistically filling it with [] when the file is empty.

@sandy081
Copy link
Member

sandy081 commented Mar 30, 2017

@jrieken Yes, I am putting default content when the file is empty.

// Place your key bindings in this file to overwrite the defaults
[]

I pushed the fix today. Fix will be available in tomorrow's build I think.

@aeschli aeschli added the verified Verification succeeded label Mar 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants