Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.11 reg : unable to search in personal settings #24063

Closed
DavidBabel opened this issue Apr 6, 2017 · 6 comments
Closed

1.11 reg : unable to search in personal settings #24063

DavidBabel opened this issue Apr 6, 2017 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues verified Verification succeeded
Milestone

Comments

@DavidBabel
Copy link

DavidBabel commented Apr 6, 2017

  • VSCode Version: 1.11
  • OS: mac

Steps to Reproduce:

  1. Open parameters
  2. Make a CMD+F
  3. You are unable to search in your existing config file

Here is an example, i search for a string in my "settings.json", but got nothing found in both in default one and personal one:
image

@chrmarti
Copy link
Contributor

chrmarti commented Apr 6, 2017

The search bar only searches the left editor with the default settings.

@DavidBabel
Copy link
Author

It worked before. Or is there a way to change this default behaviour via settings ?

@sandy081
Copy link
Member

sandy081 commented Apr 7, 2017

@DavidBabel Search bar searches for the term in the default settings editor and highlights the respective search matches in left side editor. Agreed that, this should search both in left and right editors. Will improve it. But you are not restricted from just searching in right editor. You can do following

  • From the menu bar Edit -> Find will open find widget in the right editor and you can search just there
  • If you do not like ctrl+F focussing in the Search bar, you can disable it by removing the keybinding from Keyboard shortcuts. After this ctrl+f will open Find in right editor.

But, I would be planning to make Search bar to match results in Right editor also which will not then need any of the above steps.

Thanks for filing the issue

@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues settings-editor VS Code settings editor issues and removed search Search widget and operation issues labels Apr 7, 2017
@sandy081 sandy081 added this to the April 2017 milestone Apr 7, 2017
@DavidBabel
Copy link
Author

Actually previous behaviour was nice. Advanced search for global settings with filter is very nice, but classic file search was previously allowed in user settings.

Seems like this release only bind CMD+F to the global setting search even if your cursor focus is in your personnal settings.

@DavidBabel
Copy link
Author

Here is a workaround, but as i said, previous behaviour was nice.

  {
    "key": "cmd+f",
    "command": "-settings.action.search",
    "when": "inSettingsEditor"
  },
  {
    "key": "alt+cmd+f",
    "command": "settings.action.search",
    "when": "inSettingsEditor"
  }

For me the context "inSettingsEditor" must be true when you are in the left panel, not in the right one.

sandy081 added a commit that referenced this issue Jun 22, 2017
- Find matches in editable settings editor
- Focus matches first in editable and then default settings
@sandy081
Copy link
Member

Enhanced search in Settings editor

  • Search also finds matches in right hand side editor
  • Navigating search results starts from Right hand side editor and then to Left hand side editor
  • Settings count also counts additional settings in right hand side editor

@michelkaporin michelkaporin added the verified Verification succeeded label Jun 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants