Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find widget: Error box looks strange #2448

Closed
aeschli opened this issue Jan 27, 2016 · 6 comments
Closed

Find widget: Error box looks strange #2448

aeschli opened this issue Jan 27, 2016 · 6 comments
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug verification-found Issue verification failed verified Verification succeeded
Milestone
Jan 2016

Comments

@aeschli
Copy link
Contributor

aeschli commented Jan 27, 2016

image

  • the counter label should vertically centered. Is the font smaller than in the search box?
  • The red box should have the same height as the find box, or maybe instead of a box just red label instead (i.e. in Edge: 'No matches')
@alexdima alexdima added this to the Jan 2016 milestone Jan 27, 2016
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Jan 28, 2016
@bpasero bpasero assigned isidorn and unassigned alexdima Jan 29, 2016
@isidorn isidorn added the verified Verification succeeded label Jan 29, 2016
@aeschli
Copy link
Contributor Author

aeschli commented Jan 29, 2016

Still not aligned (Linux, Version 0.10.7-insider
Commit 043a4e7)
image

@aeschli aeschli reopened this Jan 29, 2016
@aeschli aeschli assigned alexdima and unassigned isidorn Jan 29, 2016
@aeschli aeschli added verification-found Issue verification failed and removed verified Verification succeeded labels Jan 29, 2016
@isidorn
Copy link
Contributor

isidorn commented Jan 29, 2016

Hmm on the mac I do not see the red background which looks better imho. And all is aligned

screen shot 2016-01-29 at 12 10 27

@bpasero
Copy link
Member

bpasero commented Jan 29, 2016

I do and it looks off too:

image

@alexdima
Copy link
Member

I swear it was aligned when I pushed it :)

@bpasero bpasero assigned aeschli and unassigned alexdima Jan 29, 2016
bpasero added a commit that referenced this issue Jan 29, 2016
@bpasero
Find widget: Error box looks strange (fixes #2448)
6c2d51a
@aeschli
Copy link
Contributor Author

aeschli commented Jan 29, 2016

Box height is good now, but the text isn't aligned with the search text and buttons.
image

@aeschli aeschli reopened this Jan 29, 2016
@aeschli aeschli assigned bpasero and unassigned aeschli Jan 29, 2016
@aeschli
Copy link
Contributor Author

aeschli commented Jan 29, 2016

@bpasero has a fix...

@bpasero bpasero closed this as completed Jan 29, 2016
@bpasero bpasero assigned aeschli and unassigned bpasero Jan 29, 2016
@aeschli aeschli added the verified Verification succeeded label Jan 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
alexr00 added a commit that referenced this issue Jun 9, 2020
@alexr00
Show error for '/' in Windows simple file dialog
73f2586 
Fixes #2448
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug verification-found Issue verification failed verified Verification succeeded
Projects
None yet
Milestone
Jan 2016
Development

No branches or pull requests
4 participants
@bpasero @isidorn @alexdima @aeschli