Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[json] Intellisense Provides Strange Suggestions In Property Value #2468

Closed
ghost opened this issue Jan 27, 2016 · 3 comments
Closed

[json] Intellisense Provides Strange Suggestions In Property Value #2468

ghost opened this issue Jan 27, 2016 · 3 comments
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug json JSON support issues verified Verification succeeded
Milestone
July 2016

Comments

@ghost
Copy link

ghost commented Jan 27, 2016

When I'm writing an Azure RM Deployment template and I'm writing a template language expression that contains single-quoted strings inside double-quoted property values, I get some strange suggestions. I get the same thing when I try to access a resourceGroup() property via the '.' character. The pictures show the suggestions I'm getting. In these scenarios, I expect to not get any suggestions.
jsonintellisenseinpropertyvaluewithperiod
jsonintellisenseinpropertyvaluewithsinglequotedstring
@aeschli aeschli self-assigned this Jan 28, 2016
@aeschli aeschli added json JSON support issues bug Issue identified by VS Code Team member as probable bug labels Jan 28, 2016
@aeschli aeschli added this to the Jan 2016 milestone Jan 28, 2016
@aeschli aeschli changed the title JSON Intellisense Provides Strange Suggestions In Property Value [json] Intellisense Provides Strange Suggestions In Property Value Jan 28, 2016
@aeschli
Copy link
Contributor

aeschli commented Jan 28, 2016

Note that you are editing a document with no schema associated. In that case we look for similar nodes and give these as proposals. I fixed that the value of the currently edited property is no longer proposed.
There is still issue #2496 that adds funny proposal.

In the context of a Azure RM Deployment template you should have a schema association.

aeschli added a commit that referenced this issue Jan 28, 2016
@aeschli
Test fixes for #2468
706413e
@aeschli aeschli assigned bpasero and unassigned aeschli Jan 28, 2016
@bpasero
Copy link
Member

bpasero commented Jan 29, 2016

I am still seeing what the user reports:

image

@bpasero bpasero reopened this Jan 29, 2016
@bpasero bpasero added the verification-found Issue verification failed label Jan 29, 2016
@bpasero bpasero assigned aeschli and unassigned bpasero Jan 29, 2016
@aeschli aeschli modified the milestones: Feb 2016, Jan 2016 Jan 29, 2016
@aeschli aeschli modified the milestones: Backlog, Feb 2016 Feb 22, 2016
@aeschli aeschli removed the verification-found Issue verification failed label Jul 28, 2016
@aeschli aeschli modified the milestones: July 2016, Backlog Jul 28, 2016
@weinand weinand added the verified Verification succeeded label Jul 28, 2016
@weinand
Copy link
Contributor

weinand commented Jul 28, 2016

works:
2016-07-28_16-54-25

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug json JSON support issues verified Verification succeeded
Projects
None yet
Milestone
July 2016
Development

No branches or pull requests
3 participants
@bpasero @weinand @aeschli