Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Permanently prompts two times when it fails to move to trash #2541

Closed
dbaeumer opened this issue Jan 29, 2016 · 7 comments
Closed

Delete Permanently prompts two times when it fails to move to trash #2541

dbaeumer opened this issue Jan 29, 2016 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@dbaeumer
Copy link
Member

One as a message and then again in a dialog box. One time would be enough :-)
bug

@dbaeumer dbaeumer added bug Issue identified by VS Code Team member as probable bug workbench labels Jan 29, 2016
@bpasero
Copy link
Member

bpasero commented Jan 29, 2016

@dbaeumer I wonder why delete failed in the first place, I assume this is again a setup with a subst drive? I know a fix went into Electron to support moving to trash even from subst :)

@bpasero bpasero added this to the Feb 2016 milestone Jan 29, 2016
@sliepie
Copy link

sliepie commented Jan 30, 2016

@bpasero I was running into the same issue on my machine.
The recycle bin on this machine is configured the following, for all drives:
image

@bpasero
Copy link
Member

bpasero commented Jan 30, 2016

Win7?

@bpasero bpasero modified the milestones: Backlog, Feb 2016 Jan 31, 2016
@bpasero bpasero changed the title Delete Permanently prompts two times Delete Permanently prompts two times when it fails to move to trash Jan 31, 2016
@dbaeumer
Copy link
Member Author

dbaeumer commented Feb 1, 2016

@bpasero yes it is the drive subst. IMO it would be enough to prompt me once to delete permanently.

@bpasero
Copy link
Member

bpasero commented Feb 1, 2016

@dbaeumer I remember. Previously delete would silently fail without information and now you get the message at least. Windows does not support the trash when deleting from a SUBST afaik.

@dbaeumer
Copy link
Member Author

dbaeumer commented Feb 1, 2016

@bpasero yes, that makes sense. But currently I get the following dialogs:

  • A dialog asking: Are you sure you want to delete. I confirm with yes
  • A message that it can't be moved to trash. Instead you can delete permanently
  • A dialog asking: Are you sure to permanently delete.

I think the last dialog is not necessary

@bpasero
Copy link
Member

bpasero commented Feb 1, 2016

Yup, at least in case you already confirmed the confirmation for the trash.

@bpasero bpasero closed this as completed in e05c5a0 Feb 1, 2016
@bpasero bpasero modified the milestones: Feb 2016, Backlog Feb 1, 2016
@bpasero bpasero assigned dbaeumer and unassigned bpasero Feb 1, 2016
@dbaeumer dbaeumer added the verified Verification succeeded label May 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants