Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff editor: avoid hardcoded modified-side shadow #25625

Closed
bpasero opened this issue Apr 28, 2017 · 0 comments
Closed

Diff editor: avoid hardcoded modified-side shadow #25625

bpasero opened this issue Apr 28, 2017 · 0 comments
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug themes Color theme issues verified Verification succeeded
Milestone
May 2017

Comments

@bpasero
Copy link
Member

bpasero commented Apr 28, 2017

Inside diffEditor.css I see a rule for setting the shadow color between left hand and right hand side of the diff editor:

image

I suggest to remove this rule and use the scrollbar.shadow color instead.
@bpasero bpasero added the themes Color theme issues label Apr 28, 2017
@aeschli aeschli added this to the May 2017 milestone Apr 28, 2017
@aeschli aeschli closed this as completed in 9554695 May 4, 2017
@aeschli aeschli added the bug Issue identified by VS Code Team member as probable bug label May 30, 2017
@bpasero bpasero added the verified Verification succeeded label May 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug themes Color theme issues verified Verification succeeded
Projects
None yet
Milestone
May 2017
Development

No branches or pull requests
2 participants
@bpasero @aeschli