-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monokai and monokai dark backgrounds (+workbench colors) have changed #25742
Comments
/cc @cleidigh |
@Tyriar |
@cleidigh no worries 😃 I'll do a pass through first as we're so close to the release. |
@Tyriar |
Pushed the Monokai changes to release/1.12 |
oh well, I guess my workbench choices wiffed... |
@Tyriar your latest changes make the theme broken in some places. Examples: Section Header bleeding into background: You should also define colors for:
I must also admit that the new selection color is very strong: PS: what about "Monokai Dimmed"? |
@Tyriar here is my proposal based on the work from @cleidigh with some color tweaks: "colors": {
"dropdown.background": "#383852",
"list.activeSelectionBackground": "#383852",
"list.focusBackground": "#425370",
"list.inactiveSelectionBackground": "#23324e",
"list.hoverBackground": "#005070",
"list.highlightForeground": "#e58520",
"button.background": "#1e4456",
"editor.background": "#202025",
"editor.foreground": "#f8f8f2",
"editor.selectionBackground": "#49483e",
"editor.lineHighlightBackground": "#303030",
"editorCursor.foreground": "#c07020",
"editorWhitespace.foreground": "#383880",
"editorIndentGuide.background": "#505037",
"editorGroupHeader.tabsBackground": "#222228",
"editorGroup.background": "#1a1a1e",
"tab.inactiveBackground": "#333340",
"tab.border": "#000030",
"peekView.border": "#3655b5",
"panelTitle.activeForeground": "#ddffff",
"statusBar.background": "#354550",
"statusBar.debuggingBackground": "#354550",
"statusBar.noFolderBackground": "#354550",
"titleBar.activeBackground": "#354550",
"activityBar.background": "#292935",
"activityBarBadge.foreground": "#ffffff",
"activityBarBadge.background": "#3655b5",
"sideBar.background": "#232327",
"sideBarSectionHeader.background": "#424250",
"pickerGroup.foreground": "#77a5b0",
"terminal.ansiWhite": "#ddffff",
"notification.background": "#292935"
} We talked through this in the standup and feel that we should not force strong colors to the workbench for the monokai theme. We can always release a Monokai theme as extension to give this a try. |
@bpasero thanks for pointing that out, I actually had a chat with Kai about the strong accent color yesterday. Will look into alternatives today.
This was actually intentional as I was using a limited palette. I was going to get to Monokai Dimmed this morning. |
@cleidigh it's not that they were bad, the theme actually looked pretty good. Unfortunately the background color changed which changes the feel of the already established theme. |
- Focus color is now more muted - Fixed notification foreground - Added input option active border - Added input validation colors - Added title bar color Part of #25742
- Focus color is now more muted - Fixed notification foreground - Added input option active border - Added input validation colors - Added title bar color Part of #25742
For dimmed I restored the background color and removed the saturation from the blue tinted colors so @cleidigh's work is preserved for the most part. As a result it's a little lighter than before but looks fairly consistent. Also added @cleidigh please feel free to iterate on this if you want 😃 |
- Restored dimmed monokai bg colors - Set saturation of blue tinted colors to 0 - Whitespace using indent guide color - Improve contrast of inactive tab - Add inputOption.activeBorder and focusBorder Fixes #25742
All fixes pushed to master and release/1.12, should be good to go 👍 |
@Tyriar |
@cleidigh basically the goal is that they should just look good and consistent, without drastically changing the "feel" of the theme (keep the background, try to reuse existing colors). The work remaining on Monokai Dimmed is filling in a bunch of keys where it may not look right. For example many colors will fallback to the default dark theme which look alright, such as the debug toolbar, but it's the grey from the dark theme not the dimmed grey. Other things like tweaking the diff/validation/etc. colors to match the token colors would also give it a more consistent and polished look. Thanks again for the contribution! 👍 |
I know it's late in the game, maybe has to wait till May but I was just doing some debugging I noticed the status bar is the exact same color as the list separators , this is particularly noticeable personally I think the status bar should have some color, maybe steel blue or whatever. Having |
@cleidigh what do you think about this (for status bar + title bar)? This is #20242E which is part way between the editor background #1e1e1e and the activity bar badge blue #3655b5 |
We could also do a new gray in between maybe the editor and side bar? |
@Tyriar Try: #24282F what do you think? two other things :
I like the line separator idea also |
I just looked closer #24282F is too close to the background of the sidebar |
@Tyriar |
I didn't end up making a change, looking at it again I think the blue is too strong, looks strange being the only color with saturation in the workbench. |
I dig all the new themes in 1.12, as it gives each a more unique feeling! Excellent work. :) Though, one thing perplexes me: why is the Personally, I love and use Monokai because it is very colorful, and I have honestly grown attached to that little colorful badge. Fortunately, you can customize colors on top of a theme. I just wanted to throw this concern out there (rather than a whole new issue). I have had a harder time reading the badge due to the decreased color contrast as well (which may be a problem, and the gray background blends in with the icon without the color). I would have expected this behavior more in the Monokai Dimmed theme just by the name, hence my confusion. Either way, great work on the updates! |
@Tyriar |
@mckennapsean I made the badge and focus color was the Monokai pink originally but the team was opposed to it as it was a little too bold. It's very easy to fork the theme and publish a variant though. You can also override the colors in your settings file using |
The background colors have changed from the standard Monokai, we should change them back to the standard background and adjust workbench colors accordingly as Monokai is a very popular theme with clearly defined colors that users expect.
#25599
fyi @bpasero
The text was updated successfully, but these errors were encountered: