Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue: Select element border radius and color #26045

Closed
SidIcarus opened this issue May 5, 2017 · 2 comments
Closed

Issue: Select element border radius and color #26045

SidIcarus opened this issue May 5, 2017 · 2 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug themes Color theme issues verified Verification succeeded
Milestone
May 2017

Comments

@SidIcarus
Copy link

  • VSCode Version: Code 1.12.1 (f6868fc, 2017-05-04T21:18:32.269Z)
  • OS Version: Darwin x64 16.1.0

Honestly a super small issue from the looks of it.

Steps to Reproduce:

  1. Set colors for (Color should have enough contrast between each other to be able to illustrate issue
    "workbench.colorCustomizations": {
        "focusBorder": "#a3a3a3", 
        "dropdown.border": "#00FF00"
    }
  1. Click on a dropdown then click off of it as such
    select-border-radius

  • You can see in the colors reference that the dropdown has border-radius: 0
    themes-reference

  • On macos, it does not appear to be the case
    mac-select-border-radius

  • The select did not change when I tried to set the border-radius to 0 through the inspector.
@bpasero bpasero self-assigned this May 5, 2017
@bpasero bpasero added the themes Color theme issues label May 5, 2017
@bpasero bpasero added this to the May 2017 milestone May 5, 2017
@bpasero
Copy link
Member

bpasero commented May 6, 2017

@SidIcarus to be clear, you are describing the issue here that a select dropdown that has a border and also focus shows a little bit of UI glitch due to the border radius on it?

@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label May 8, 2017
@bpasero bpasero closed this as completed in 674200f May 8, 2017
@bpasero
Copy link
Member

bpasero commented May 8, 2017

When a dropdown element on macOS gets focus, I am removing the border from the element to avoid this UX clash.

@roblourens roblourens added the verified Verification succeeded label Jun 2, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug themes Color theme issues verified Verification succeeded
Projects
None yet
Milestone
May 2017
Development

No branches or pull requests
3 participants
@roblourens @bpasero @SidIcarus