Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update icon in explorer (or search,...) when language mode changes in editor #26260

Closed
jens1o opened this issue May 9, 2017 · 2 comments
Closed

Update icon in explorer (or search,...) when language mode changes in editor #26260

jens1o opened this issue May 9, 2017 · 2 comments
Assignees
@bpasero
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
September 2017

Comments

@jens1o
Copy link
Contributor

jens1o commented May 9, 2017 •
edited

  • VSCode Version: 1.12.1
  • OS Version: Windows 10 Home

image

Steps to reproduce(in a more general way):

  1. Install vscode-icons (or just use the icon set shipped with vscode) and configure to use it
  2. Reload and then open a folder.
  3. Create a new file called test.unknown
  4. See there is no icon provided.
  5. Paste in the following: let random = Math.random();.
  6. Change the Language Mode to JS.
  7. After closing and reopen the editor the icon should be shown both in the tab and in the open editors, but not in the file explorer.
    image
@aeschli aeschli assigned bpasero and unassigned aeschli May 9, 2017
@bpasero bpasero changed the title Icon won't be shown in file explorer when there is an icon for a used language id. Update icon in explorer when language mode changes in editor May 9, 2017
@bpasero bpasero added file-explorer Explorer widget issues feature-request Request for new features or functionality labels May 9, 2017
@bpasero bpasero removed their assignment May 9, 2017
@bpasero
Copy link
Member

bpasero commented May 9, 2017 •
edited

Yeah, the explorer (really any component outside the editor) is not knowing the defined language mode of an opened editor, it can only go by path.

@bpasero bpasero changed the title Update icon in explorer when language mode changes in editor Update icon in explorer (or search,...) when language mode changes in editor May 9, 2017
@bpasero bpasero added this to the September 2017 milestone Sep 7, 2017
@bpasero bpasero self-assigned this Sep 7, 2017
@bpasero bpasero closed this as completed in b1a437c Sep 7, 2017
@bpasero bpasero added the verification-needed Verification of issue is requested label Sep 26, 2017
@bpasero
Copy link
Member

bpasero commented Sep 26, 2017

Verify: changing the language mode in the editor updates icons in explorer.

@isidorn isidorn added the verified Verification succeeded label Sep 26, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
4 participants
@bpasero @isidorn @aeschli @jens1o