Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support [line, col] in terminal links #26330

Closed
Tyriar opened this issue May 9, 2017 · 4 comments · Fixed by #29212
Closed

Support [line, col] in terminal links #26330

Tyriar opened this issue May 9, 2017 · 4 comments · Fixed by #29212
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
June 2017

Comments

@Tyriar
Copy link
Member

Tyriar commented May 9, 2017

tslint outputs errors in this format:

ERROR: src/foo.ts[61, 28]: Missing semicolon

/cc @jonaskello

Related:
@Tyriar Tyriar added feature-request Request for new features or functionality terminal Integrated terminal issues labels May 9, 2017
@Tyriar Tyriar self-assigned this May 9, 2017
@Tyriar Tyriar changed the title Support [x, y] in terminal links Support [line, col] in terminal links May 9, 2017
@Tyriar Tyriar mentioned this issue May 9, 2017
Closed
@Tyriar Tyriar added the help wanted Issues identified as good community contribution opportunities label May 9, 2017
@Tyriar Tyriar added this to the Backlog milestone May 9, 2017
@Tyriar Tyriar mentioned this issue May 9, 2017
Closed
@Krzysztof-Cieslak Krzysztof-Cieslak mentioned this issue Jun 21, 2017
Merged
@Tyriar Tyriar modified the milestones: June 2017, Backlog Jun 21, 2017
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Jun 26, 2017
@roblourens roblourens added the verification-found Issue verification failed label Jun 28, 2017
@roblourens roblourens reopened this Jun 28, 2017
@roblourens
Copy link
Member

roblourens commented Jun 28, 2017 •
edited

Doesn't work for me when there's a space between line and col, it looks like tslint is outputting it that way

Top goes to correct line/col, bottom just goes to the file
image

@Tyriar
Copy link
Member Author

Tyriar commented Jun 28, 2017

@roblourens do you have an example program that outputs like this?

@roblourens
Copy link
Member

tslint apparently does, from the example above?

@roblourens
Copy link
Member

I actually can't click src/foo.ts at all in this example

image

@Tyriar Tyriar closed this as completed in 9ac6c54 Jun 28, 2017
@Tyriar Tyriar added verified Verification succeeded and removed verification-found Issue verification failed labels Jun 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
June 2017
Development

Successfully merging a pull request may close this issue.

Add Support [line, col] in terminal links
2 participants
@roblourens @Tyriar