Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search: unable to include/exclude via glob patterns #26634

Closed
bpasero opened this issue May 15, 2017 · 2 comments
Closed

Search: unable to include/exclude via glob patterns #26634

bpasero opened this issue May 15, 2017 · 2 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Milestone
May 2017

Comments

@bpasero
Copy link
Member

bpasero commented May 15, 2017 •
edited

Steps to Reproduce:

  1. "Find in folder"
  2. append a *.css at the end to enable glob matching

=> you get an unhelpful error like this one:
image

This used to work previously without having to enable the glob option. I would just detect glob patterns in the pattern and remove the leading ./, that seems to fix it.
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues labels May 15, 2017
@bpasero bpasero added this to the May 2017 milestone May 15, 2017
@bpasero
Copy link
Member Author

bpasero commented May 15, 2017

Setting to May, imho this is a bad regression.

@bpasero bpasero changed the title Search: unable to include/exclude via glob patterns in this case Search: unable to include/exclude via glob patterns May 15, 2017
@bpasero bpasero added important Issue identified as high-priority and removed important Issue identified as high-priority labels May 15, 2017
@roblourens
Copy link
Member

roblourens commented May 15, 2017 •
edited

I would just detect glob patterns in the pattern and remove the leading ./

Yeah I think this is what I should do.

This was referenced May 24, 2017
Closed
Closed
dbaeumer pushed a commit that referenced this issue May 26, 2017
@roblourens @dbaeumer
Fix #26634 - if a ./ include pattern contains glob characters, igno…
dfff4c5 
…re the `./`
@bpasero bpasero added the verified Verification succeeded label May 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Projects
None yet
Milestone
May 2017
Development

No branches or pull requests
2 participants
@roblourens @bpasero