Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can no longer move editor focus when editor is not code editor #2736

Closed
bpasero opened this issue Feb 5, 2016 · 0 comments
Closed

Can no longer move editor focus when editor is not code editor #2736

bpasero opened this issue Feb 5, 2016 · 0 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Milestone
Feb 2016

Comments

@bpasero
Copy link
Member

bpasero commented Feb 5, 2016

For the following editors, it is no longer possible to make them active by clicking with the mouse into them or using Cmd+1/2/3:

  • binary editor (images)
  • binary diff editor (compare 2 images)
  • markdown preview

The reason is that I removed the tabIndex attribute from those and thus we no longer detect when keyboard focus reaches them...
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Feb 5, 2016
@bpasero bpasero added this to the Feb 2016 milestone Feb 5, 2016
@bpasero bpasero self-assigned this Feb 5, 2016
@bpasero bpasero added the important Issue identified as high-priority label Feb 5, 2016
@bpasero bpasero closed this as completed in 8435ddc Feb 5, 2016
@bpasero bpasero assigned isidorn and unassigned bpasero Feb 5, 2016
@isidorn isidorn added the verified Verification succeeded label Feb 26, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Milestone
Feb 2016
Development

No branches or pull requests
2 participants
@bpasero @isidorn