-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global activity action: align with existing patterns #27461
Comments
@bpasero Going along with this, how could we display a badge without reinventing the wheel? |
@joaomoreno I would make |
Pushed some cleanup but overall think we can leave this as is. My original complaint to move to the actions (#27464) was meanwhile fixed, so I think the solution works quite nicely. |
@bpasero thanks for cleaning this up nicely |
Provided we decide to keep the global activity action in the bottom of the activity bar, I suggest to tackle some debt associated with it:
GLOBAL
scope withinIActionBarRegistry
that can be used to register an action bar contributor for this scope. the activity bar part can then easily read out those actions from the global scope and use themIGlobalActivity
that has to return actions that will show on click in the context menu we should just register an instance ofIAction
that inside itsrun
method shows actions using the context menu serviceGiven these changes, I think we no longer need
activity.ts
and we basically have the old concept we used to have which is to register a global action that just implements everything through therun
method./cc @joaomoreno
The text was updated successfully, but these errors were encountered: