Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrated terminal throws assertion failure on Windows #27534

Closed
michelkaporin opened this issue May 30, 2017 · 4 comments
Closed

Integrated terminal throws assertion failure on Windows #27534

michelkaporin opened this issue May 30, 2017 · 4 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded windows VS Code on Windows issues
Milestone
June 2017

Comments

@michelkaporin
Copy link
Contributor

  • VSCode Version: Code - Insiders 1.13.0-insider (c2a17a7, 2017-05-30T05:14:15.320Z)
  • OS Version: Windows_NT ia32 10.0.14393
  • Extensions:
Extension Author Version
vscode-color anseki 0.4.1
jshint dbaeumer 0.10.15
vscode-eslint dbaeumer 1.2.11
tslint eg2 0.15.0
vscode-npm-script eg2 0.1.9
PowerShell ms-vscode 1.1.0
debugger-for-chrome msjsdiag 3.1.2
vscode-icons robertohuertasm 7.8.1
vscode-open-in-github sysoev 1.5.0

Steps to Reproduce:

  1. Open integrated terminal (cmd.exe)
  2. Squeeze the window in height to the minimum
    -> Runtime error.

runtime_error
@Tyriar
Copy link
Member

Tyriar commented May 30, 2017

@rprichard fyi, I'm guessing this happens when resizing to a height of 0.

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels May 30, 2017
@Tyriar Tyriar added this to the Backlog milestone May 30, 2017
@Tyriar Tyriar added the windows VS Code on Windows issues label May 30, 2017
@rprichard
Copy link

fyi, I'm guessing this happens when resizing to a height of 0.

Probably. A width of 0 would also hit the assertion. Maybe winpty should allow it, or maybe clients shouldn't pass a size of 0. I'm not sure.

@thai-ng
Copy link

thai-ng commented May 31, 2017 •
edited

When VSCode is maximized, starting Terminal also throws the same assert

@Tyriar
Copy link
Member

Tyriar commented May 31, 2017

@rprichard yeah I was thinking of preventing it on our side; don't send < 1 and use display:none to prevent the layout screwing up.

@Tyriar Tyriar modified the milestones: May 2017, Backlog, June 2017 May 31, 2017
@Tyriar Tyriar removed the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label May 31, 2017
@Tyriar Tyriar modified the milestones: July 2017, June 2017 Jun 22, 2017
@Tyriar Tyriar closed this as completed in 307d8b2 Jun 22, 2017
@Tyriar Tyriar mentioned this issue Jun 27, 2017
Closed
@michelkaporin michelkaporin added the verified Verification succeeded label Jun 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Milestone
June 2017
Development

No branches or pull requests
4 participants
@rprichard @Tyriar @michelkaporin @thai-ng