Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion list jumps between below and above position #27649

Closed
chrmarti opened this issue May 30, 2017 · 3 comments · Fixed by #62115
Closed

Suggestion list jumps between below and above position #27649

chrmarti opened this issue May 30, 2017 · 3 comments · Fixed by #62115
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete ux User experience issues verified Verification succeeded
Milestone

Comments

@chrmarti
Copy link
Contributor

  • VSCode Version: Code - Insiders 1.13.0-insider (afe47dc, 2017-05-30T10:34:18.253Z)
  • OS Version: Darwin x64 15.6.0
  • Extensions: none

Testing #27315

It seems to be triggered by an entry with a long doc:
may-30-2017 14-39-47

@ramya-rao-a
Copy link
Contributor

well yes. The long docs cannot be fit under the cursor, so the widget moves above.

This behavior exists today as well without the docs expanded.

Just above the bottom of the editor, type something that gives you say 4 suggestions and all fit below the cursor. Now keep backspacing, suggestion list grows and widget goes above the cursor.

One thing we can do here is, that once the widget moves above the cursor, it remains above even if the next docs is small enough to fit below the cursor.

Thoughts?

@ramya-rao-a ramya-rao-a added the suggest IntelliSense, Auto Complete label May 30, 2017
@chrmarti
Copy link
Contributor Author

Sounds good, that would improve these cases.

@ramya-rao-a ramya-rao-a added the bug Issue identified by VS Code Team member as probable bug label May 30, 2017
@ramya-rao-a ramya-rao-a modified the milestones: May 2017, June 2017 May 30, 2017
@ramya-rao-a
Copy link
Contributor

From @roblourens in #28140

jun-06-2017 11-49-29

@ramya-rao-a ramya-rao-a modified the milestones: July 2017, June 2017 Jun 23, 2017
@ramya-rao-a ramya-rao-a modified the milestones: Backlog, July 2017 Jul 18, 2017
@ramya-rao-a ramya-rao-a added the help wanted Issues identified as good community contribution opportunities label Jul 18, 2017
@jrieken jrieken added ux User experience issues and removed help wanted Issues identified as good community contribution opportunities labels Nov 21, 2018
riltsken added a commit to riltsken/vscode that referenced this issue Nov 25, 2018
Fixes: microsoft#27649

Long docs when cursor is near the bottom will jump to the top to allow for more space, but if the next suggestion docs are smaller it will jump back down creating a jarring experience when flipping through suggestions quickly. Pin the widget to the top if it flips to the top once so that the experience is more fluid.

This is just one way we might handle it. Open to suggestions as this is my first PR to VSCode.
@ramya-rao-a ramya-rao-a removed this from the Backlog milestone Dec 3, 2018
@ramya-rao-a ramya-rao-a added this to the November 2018 milestone Dec 3, 2018
ramya-rao-a pushed a commit that referenced this issue Dec 3, 2018
Fixes: #27649

Long docs when cursor is near the bottom will jump to the top to allow for more space, but if the next suggestion docs are smaller it will jump back down creating a jarring experience when flipping through suggestions quickly. Pin the widget to the top if it flips to the top once so that the experience is more fluid.

This is just one way we might handle it. Open to suggestions as this is my first PR to VSCode.
@miguelsolorio miguelsolorio added the verified Verification succeeded label Dec 5, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete ux User experience issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants