Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover on the new icon or the update badge doesnt show any tooltip #27779

Closed
ramya-rao-a opened this issue May 31, 2017 · 13 comments
Closed

Hover on the new icon or the update badge doesnt show any tooltip #27779

ramya-rao-a opened this issue May 31, 2017 · 13 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues verified Verification succeeded

Comments

@ramya-rao-a
Copy link
Contributor

Testing #27454

When an update is available, the badge shows up.
For some, it may not be clear what the icon/badge is/does.
Having a tooltip and an aria-label will help

@isidorn
Copy link
Contributor

isidorn commented Jun 1, 2017

I agree. What would you suggest the hover says when there is no update?

@isidorn isidorn added this to the June 2017 milestone Jun 1, 2017
@ramya-rao-a
Copy link
Contributor Author

Its tricky. The gear icon itself opens up another menu whether there is an update or not. So I wonder if the tooltip should be about the menu or that an update is available.

btw does the badge go away after you click the gear icon and you don't restart when update is available?

@isidorn
Copy link
Contributor

isidorn commented Jun 1, 2017

No the badge does not go away until you have installed the update.

When there is a badge the tooltip is easy "Update available", however when there is no badge we can simply have no tooltip or I am open for suggestions

@ramya-rao-a
Copy link
Contributor Author

ramya-rao-a commented Jun 1, 2017

No the badge does not go away until you have installed the update.

My Insiders (on Mac) is still on 5/31. The gear icon does not have the badge. But the menu item says "Restart to update..."

@isidorn
Copy link
Contributor

isidorn commented Jun 2, 2017

@ramya-rao-a Nice find. That is a seperate issue, can you please file it and I will fix it in June since we are not shipping this feature in may

@ramya-rao-a
Copy link
Contributor Author

@isidorn Am not getting a consistent repro for that, will file a new issue if I do

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug workbench labels Jun 14, 2017
@isidorn isidorn modified the milestones: Backlog, June 2017 Jun 21, 2017
@julielerman
Copy link

Adding in some thoughts if it helps to decide what the tooltip should say. Seeing that number badge made me look at my current extensions but nothing there indicated an update. I figured it had to be VS Code itself. So Maybe "There's a new version of Visual Studio Code available, restart to begin the update" or something along those lines. I had just updated a few days ago . I do realize there was a patch, but normally we anticipate only monthly updates. It would be nice to somehow have that information available even through some kind of "more details..." link, rather than just blindly updating.

@joaomoreno joaomoreno modified the milestones: July 2017, Backlog Jul 24, 2017
@chrmarti
Copy link
Contributor

chrmarti commented Aug 2, 2017

I don't see the tooltip with:

  • VSCode Version: Code - Insiders 1.15.0-insider (ffacb34, 2017-08-01T23:24:13.856Z)
  • OS Version: Darwin x64 16.6.0

@chrmarti chrmarti reopened this Aug 2, 2017
@chrmarti chrmarti added the verification-found Issue verification failed label Aug 2, 2017
@isidorn isidorn modified the milestones: August 2017, July 2017 Aug 3, 2017
@joaomoreno
Copy link
Member

joaomoreno commented Aug 8, 2017

@chrmarti Do you mean you don't see a tooltip when there isn't an update available?

@chrmarti
Copy link
Contributor

chrmarti commented Aug 8, 2017

That is when there is a badge indicating an update is available.

@julielerman
Copy link

@joaomoreno thanks for the fix!

@bpasero
Copy link
Member

bpasero commented Aug 29, 2017

On Windows I am not seeing the title unless it is set on the parent <li> container. See here in devtools what I had to do to see it:

image

@bpasero bpasero reopened this Aug 29, 2017
@bpasero bpasero assigned bpasero and unassigned joaomoreno Aug 29, 2017
@bpasero bpasero modified the milestones: September 2017, August 2017 Aug 30, 2017
@bpasero bpasero added debt Code quality issues and removed verification-found Issue verification failed labels Aug 30, 2017
@bpasero
Copy link
Member

bpasero commented Aug 30, 2017

The handling of tooltips in activity bar is done in a very bad way. Should clean this up in debt week, and reuse the updateTooltip method we have on the action item base class.

@bpasero bpasero closed this as completed in 7712905 Sep 4, 2017
@ramya-rao-a ramya-rao-a added the verified Verification succeeded label Sep 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants