-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hover on the new icon or the update badge doesnt show any tooltip #27779
Comments
I agree. What would you suggest the hover says when there is no update? |
Its tricky. The gear icon itself opens up another menu whether there is an update or not. So I wonder if the tooltip should be about the menu or that an update is available. btw does the badge go away after you click the gear icon and you don't restart when update is available? |
No the badge does not go away until you have installed the update. When there is a badge the tooltip is easy "Update available", however when there is no badge we can simply have no tooltip or I am open for suggestions |
My Insiders (on Mac) is still on 5/31. The gear icon does not have the badge. But the menu item says "Restart to update..." |
@ramya-rao-a Nice find. That is a seperate issue, can you please file it and I will fix it in June since we are not shipping this feature in may |
@isidorn Am not getting a consistent repro for that, will file a new issue if I do |
Adding in some thoughts if it helps to decide what the tooltip should say. Seeing that number badge made me look at my current extensions but nothing there indicated an update. I figured it had to be VS Code itself. So Maybe "There's a new version of Visual Studio Code available, restart to begin the update" or something along those lines. I had just updated a few days ago . I do realize there was a patch, but normally we anticipate only monthly updates. It would be nice to somehow have that information available even through some kind of "more details..." link, rather than just blindly updating. |
I don't see the tooltip with:
|
@chrmarti Do you mean you don't see a tooltip when there isn't an update available? |
That is when there is a badge indicating an update is available. |
@joaomoreno thanks for the fix! |
The handling of tooltips in activity bar is done in a very bad way. Should clean this up in debt week, and reuse the |
Testing #27454
When an update is available, the badge shows up.
For some, it may not be clear what the icon/badge is/does.
Having a tooltip and an aria-label will help
The text was updated successfully, but these errors were encountered: