Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript language service dies after 5 times updating 'typescript.npm' to the wrong value #27817

Closed
michelkaporin opened this issue Jun 1, 2017 · 2 comments
Closed

TypeScript language service dies after 5 times updating 'typescript.npm' to the wrong value #27817

michelkaporin opened this issue Jun 1, 2017 · 2 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues typescript Typescript support issues verified Verification succeeded
Milestone
June 2017

Comments

@michelkaporin
Copy link
Contributor

Testing #27695

  • VSCode Version: 1.13
  • OS Version: Windows

Steps to Reproduce:

  1. Follow testing steps as in Test TypeScript.npm Setting #27695.
  2. Try to set typescript.npm to different values that do not exist.
    Observe how the 'could not install typings' notification appears. After 5th time of setting it to the wrong value the following notification appears:

"The TypeScript language service died 5 times right after it got started. The service will not be restarted."

However, if I set it in to the correct value on the sixth time, I successfully get typings for JQuery.

Repeating the steps above again leads to "The TypeScript language service died 5 times right after it got started. The service will not be restarted." second time (without restarting VS Code).

image

As a user I would be happy not to receive the message about the dead service in this case (as it still restarts after 6th time?).
@mjbvz mjbvz added this to the June 2017 milestone Jun 1, 2017
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues typescript Typescript support issues labels Jun 1, 2017
@mjbvz mjbvz closed this as completed in 732824c Jun 13, 2017
@mjbvz mjbvz mentioned this issue Jun 14, 2017
Closed
@roblourens
Copy link
Member

Reproing this on 1.13, after I change typescript.npm, the "could not install typings" message appears immediately. On 1.14, there is a delay of 5-7s. Is that expected?

@roblourens roblourens added the verified Verification succeeded label Jun 29, 2017
@mjbvz
Copy link
Contributor

mjbvz commented Jun 29, 2017

Yes, I believe we now correctly restart the TS server in 1.14 which is what causes the delay

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues typescript Typescript support issues verified Verification succeeded
Projects
None yet
Milestone
June 2017
Development

No branches or pull requests
3 participants
@roblourens @michelkaporin @mjbvz