Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug Repl: output of same value no longer aggregated #27856

Closed
bpasero opened this issue Jun 1, 2017 · 8 comments
Closed

Debug Repl: output of same value no longer aggregated #27856

bpasero opened this issue Jun 1, 2017 · 8 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jun 1, 2017

I am not sure when we lost support for this but we used to show a little number next to the output if the output was identical to the previous output, much like Chrome console works:

image

I am no longer seeing this in the repl:

image

@bpasero bpasero added debug Debug viewlet, configurations, breakpoints, adapter issues debug-console labels Jun 1, 2017
@isidorn isidorn added this to the June 2017 milestone Jun 2, 2017
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Jun 6, 2017
@isidorn isidorn closed this as completed in b97d6d3 Jun 6, 2017
@isidorn
Copy link
Contributor

isidorn commented Jun 6, 2017

Please note that in your picture you are outputing an object which we never supported. Though what you are doing in chrome picture should work

for (var i = 0; i < 20; i++) {
    console.log("Hello world");
}

@weinand weinand added the verification-found Issue verification failed label Jun 28, 2017
@weinand
Copy link
Contributor

weinand commented Jun 28, 2017

running the for loop from above with the "legacy" protocol results in this:
2017-06-28_16-17-44

running it with "inspector" protocol in this:
2017-06-28_16-19-01

reopening.

@weinand weinand reopened this Jun 28, 2017
@isidorn
Copy link
Contributor

isidorn commented Jun 28, 2017

The issue is how the events are coming from the node extensions, the following sample shows that everything is fine on the vsocde side

setInterval(() => {
    console.log("Hello world");

}, 50)

However the legacy adapter seems to append different pieces together when they are happening shortly afterwards.
I do not plan to fix this on the vscode side as I would have to split the output which is coming together by newlines which would bring me some other pain.
@weinand if you want you can tackle it on the adapter side, closing this as I plan to take no action

@isidorn isidorn closed this as completed Jun 28, 2017
@bpasero bpasero added the verified Verification succeeded label Jun 28, 2017
@weinand
Copy link
Contributor

weinand commented Jun 28, 2017

I'm in favour of disabling this feature for now because it does not provide a user experience that is understandable. Why are identical strings sometimes aggregated and sometimes they are not?

Compare the console in Chrome Dev Tools with both VS Code protocols to understand what I mean.

E.g. compare the output of this snippet in the "inspector" protocol and Chrome Dev Tools:

for (var i = 0; i < 20; i++) {
    console.log("Hello\nWorld");
}

I'm not asking to fix this, but we should disable it.

@weinand weinand reopened this Jun 28, 2017
@isidorn
Copy link
Contributor

isidorn commented Jun 29, 2017

I am fine disabling it. @bpasero objections?

@bpasero
Copy link
Member Author

bpasero commented Jun 29, 2017

No objections as I am not using this feature. Btw I verified this using extension debugging where it seems to work fine.

@isidorn isidorn removed verification-found Issue verification failed verified Verification succeeded labels Jun 29, 2017
@isidorn
Copy link
Contributor

isidorn commented Jun 29, 2017

To verify: quickly try out if the repl properly shows strings sent from the adapter. And verify it does not concatanate them

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug and removed bug Issue identified by VS Code Team member as probable bug labels Jun 29, 2017
@bpasero
Copy link
Member Author

bpasero commented Jun 30, 2017

Verified for EH debugging.

@bpasero bpasero added the verified Verification succeeded label Jun 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants