-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug Repl: output of same value no longer aggregated #27856
Comments
Please note that in your picture you are outputing an object which we never supported. Though what you are doing in chrome picture should work
|
The issue is how the events are coming from the node extensions, the following sample shows that everything is fine on the vsocde side
However the legacy adapter seems to append different pieces together when they are happening shortly afterwards. |
I'm in favour of disabling this feature for now because it does not provide a user experience that is understandable. Why are identical strings sometimes aggregated and sometimes they are not? Compare the console in Chrome Dev Tools with both VS Code protocols to understand what I mean. E.g. compare the output of this snippet in the "inspector" protocol and Chrome Dev Tools: for (var i = 0; i < 20; i++) {
console.log("Hello\nWorld");
} I'm not asking to fix this, but we should disable it. |
I am fine disabling it. @bpasero objections? |
No objections as I am not using this feature. Btw I verified this using extension debugging where it seems to work fine. |
To verify: quickly try out if the repl properly shows strings sent from the adapter. And verify it does not concatanate them |
Verified for EH debugging. |
I am not sure when we lost support for this but we used to show a little number next to the output if the output was identical to the previous output, much like Chrome console works:
I am no longer seeing this in the repl:
The text was updated successfully, but these errors were encountered: