Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Emmet Commands doesn't show emmet commands when in the Interactive Playground #27890

Closed
ramya-rao-a opened this issue Jun 2, 2017 · 7 comments
Closed

Show Emmet Commands doesn't show emmet commands when in the Interactive Playground #27890

ramya-rao-a opened this issue Jun 2, 2017 · 7 comments
Assignees
@chrmarti
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
June 2017

Comments

@ramya-rao-a
Copy link
Contributor

  • VSCode Version: 1.12 or 1.13
  • OS Version: any

Steps to Reproduce:

  1. Go to the interactive playground
  2. Run the command "Show Emmet Commands" in the command palet

Observe that no commands are shown
@ramya-rao-a
Copy link
Contributor Author

@chrmarti Also the emmet section in the playground needs to change for the next milestone

@ramya-rao-a ramya-rao-a added this to the June 2017 milestone Jun 2, 2017
@chrmarti
Copy link
Contributor

chrmarti commented Jun 2, 2017

Same when no editor is open. The command palette does not list the Emmet commands when there is no active text editor it seems.

@chrmarti chrmarti added bug Issue identified by VS Code Team member as probable bug feature-request Request for new features or functionality workbench and removed feature-request Request for new features or functionality labels Jun 6, 2017
@chrmarti
Copy link
Contributor

@ramya-rao-a I'll just make it an EditorAction with precondition: EditorContextKeys.writable like BasicEmmetEditorAction. Or do you have other plans with this?

@ramya-rao-a
Copy link
Contributor Author

You are taking about the Show Emmet Commands command?

@chrmarti
Copy link
Contributor

@ramya-rao-a Yes.

@ramya-rao-a
Copy link
Contributor Author

Sure, I am not planning to touch that one for the current ongoing emmet work

@chrmarti
Copy link
Contributor

@ramya-rao-a What do we need to do for the Interactive Playground?

@ramya-rao-a ramya-rao-a removed their assignment Jun 26, 2017
chrmarti added a commit that referenced this issue Jun 26, 2017
@chrmarti
Only show when Emmet commands are shown (#27890)
7eda892
@michelkaporin michelkaporin added the verified Verification succeeded label Jun 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrmarti chrmarti

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
June 2017
Development

No branches or pull requests
3 participants
@michelkaporin @chrmarti @ramya-rao-a