Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable quick fix #27961

Closed
andy-hanson opened this issue Jun 3, 2017 · 10 comments · Fixed by #33982
Closed

Option to disable quick fix #27961

andy-hanson opened this issue Jun 3, 2017 · 10 comments · Fixed by #33982
Assignees
Labels
editor-code-actions Editor inplace actions (Ctrl + .) feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities release-notes Release notes issues verification-needed Verification of issue is requested verified Verification succeeded

Comments

@andy-hanson
Copy link

andy-hanson commented Jun 3, 2017

  • VSCode Version: 1.11.0-Insider
  • OS Version: Manjaro Gellivara 17.0.1

Steps to Reproduce:

  1. Open a C# file.
  2. Start writing anything.
  3. Every time you type a character, the light bulb on the left will flash off, then flash back again.

shot

This is extremely irritating. I'd rather not get any suggestions at all.

  1. (optional) Actually follow the suggestions.

shot2

See also #14840.

@vscodebot vscodebot bot added the insiders label Jun 3, 2017
@jrieken jrieken added editor-code-actions Editor inplace actions (Ctrl + .) feature-request Request for new features or functionality labels Jun 6, 2017
@Xelnath
Copy link

Xelnath commented Jun 14, 2017

YES PLEASE REMOVE THIS - or add an option. It keeps blocking my ability to click on the 'breakpoint' space for the current line.

@jrieken
Copy link
Member

jrieken commented Jun 14, 2017

It keeps blocking my ability to click on the 'breakpoint' space for the current line.

We are aware of conflicts in that little space, for your breakpoint challenge you should know that you can always hit F9 to set a breakpoint

@Xelnath
Copy link

Xelnath commented Jun 14, 2017

You know, I don't mind conflicts happening.... but the number of times I've wanted to add a breakpoint to a line? Thousands.

The number of times I've wanted to 'extract function' in c#? zero

@vuelto
Copy link

vuelto commented Jun 21, 2017

Agreed,
Please make this optional. I still want Ctrl->Dot to work but I don't want light bulbs to haunt my every coding moment.

@jrieken jrieken added good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities labels Jun 22, 2017
@asakharov-tr
Copy link

Yes, please make it optional.
I really don't want to extract any functions, I just want to trigger a breakpoint.

@jrieken
Copy link
Member

jrieken commented Jul 10, 2017

Sorry, this is unlikely to happen because we spend all of our time reading worthless comments in the spirit of "+1", "Me too", "Really needed" etc. etc. [irony: off]

@zcr1
Copy link

zcr1 commented Jul 30, 2017

I would love this option as a new user of vscode it's distracting.

@vuelto
Copy link

vuelto commented Jul 30, 2017

Here's another worthless comment for you. This thread exemplifies the problem with open source communities. Instead of saying "message received" you say "worthless comments". You may as well scream, "YOU ARE NOT WORTHY OF USING MY SOFTWARE!"

Message Received.

@wheatandtares
Copy link

Maybe it's just a quick z-level issue, maybe it's a massive refactor. We don't know. In any case, let's continue the established VSCode pattern of being able to disable the features that get in our way.

Visual Studio Code has established itself in the editor space with a reputation for allowing its users to configure the editors exactly how they want it. Little things like ...

"explorer.enableDragAndDrop": false
"editor.snippetSuggestions": "none",
"editor.minimap.enabled": false,
"git.enabled": false,
"git.path": null,
"git.autofetch": false,
"editor.quickSuggestions": true,
"workbench.editor.enablePreviewFromQuickOpen": false

... Are incredibly helpful for me and make me absolutely LOVE and RAVE about VSCode. If it weren't for that approach to features, I would have written off VSCode as a "curated UX" editor over a year ago and told everyone not to use it.

MSFT Product Owners and UX people want to help us with features, which is great. These features help some of us out and slow others of us down. We all have different tastes, patterns, and ways of using computers. Your editor of choice should work the way YOU want it to, to speed YOU up as much as possible. And the Visual Studio Code team has created a solid reputation that this idea is embraced. This is why VSCode became my editor of choice.

There are three options: Communicate why this change request is such a big deal that you won't do it, prioritize it, or begin the degradation of VSCode's established reputation for embracing the fact that everyone wants different things in their editor.

Additionally, I'd like to mention that we're not asking the VSCode team to increase the number of "conflicts in that little space". We're asking you to help us solve it ourselves by disabling the lightbulb that none of us in this thread want. We don't want to wait for the VSCode UX team to get around to fixing the UX conflicts, they have much bigger fish to fry I'm sure.

@jrieken must have been having a bad day, and that's okay. It happens to all of us.

Though if he wasn't just having a bad day, then what's the message here? Stop communicating how we think VSCode should be improved and wait for the VSCode UX team to curate the Perfect Little Bar With No Conflicts? Please...

@jrieken
Copy link
Member

jrieken commented Aug 14, 2017

Maybe it's just a quick z-level issue, maybe it's a massive refactor. We don't know.

Sorry, if that wasn't clear but this issue is labeled with beginner and help wanted which means it's fairly easy to do. Ask me for a code pointer and in no time you will be a VS Code code contributor. Why isn't that cool?

We're asking you to help us solve it ourselves by disabling the lightbulb that none of us in this thread want.

You are right, that's why this issue is titled "Option to disable quick fix". I am not holding back because I want to over-complicate this problem I simple have too little time to work off-plan on little issues like this. Hence, "help wanted"

Last, there is the voting-feature in GH. Please use it as it allows us to sort issues by reactions/emotions. I cannot sort by comments saying +1 but I can sort by issues being up-voted. That's how we prioritise.

I am sorry that the irony in #27961 (comment) wasn't clear enough. Please understand that you help us and yourself by being using GH-emotions.

mjbvz added a commit to mjbvz/vscode that referenced this issue Sep 8, 2017
Fixes microsoft#27961

Adds a new `editor.lightbulb.enabled` setting to enable/disable the code actions lighbulb. You can still trigger code actions manually
mjbvz added a commit that referenced this issue Sep 13, 2017
Fixes #27961

Adds a new `editor.lightbulb.enabled` setting to enable/disable the code actions lighbulb. You can still trigger code actions manually
@mjbvz mjbvz added this to the September 2017 milestone Sep 13, 2017
@mjbvz mjbvz added the verification-needed Verification of issue is requested label Sep 13, 2017
@isidorn isidorn added the verified Verification succeeded label Sep 26, 2017
@jrieken jrieken added the release-notes Release notes issues label Sep 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-code-actions Editor inplace actions (Ctrl + .) feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities release-notes Release notes issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants