Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emmet resolves invalid format #27975

Closed
jens1o opened this issue Jun 3, 2017 · 6 comments
Closed

Emmet resolves invalid format #27975

jens1o opened this issue Jun 3, 2017 · 6 comments
Assignees
@ramya-rao-a
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Milestone
June 2017

Comments

@jens1o
Copy link
Contributor

jens1o commented Jun 3, 2017

  • VSCode Version: Code - Insiders 1.13.0-insider (f977399, 2017-06-02T10:54:04.063Z)
  • OS Version: Windows_NT ia32 10.0.15063
  • Extensions:
Extension Author Version
vscode-reveal evilz 0.0.9
php-intellisense felixfbecker 1.3.0
auto-close-tag formulahendry 0.4.2
php-docblocker neilbrayfield 1.2.0
vscode-icons robertohuertasm 7.8.1
Material-theme zhuangtongfa 2.8.4

image
That isn't valid at all, a tag MUST be alphabetical, and must not include numbers.
@vscodebot vscodebot bot added the insiders label Jun 3, 2017
@jens1o
Copy link
Contributor Author

jens1o commented Jun 3, 2017

Another thing:
image

@ramya-rao-a
Copy link
Contributor

haha, nice catch

@ramya-rao-a ramya-rao-a added the bug Issue identified by VS Code Team member as probable bug label Jun 5, 2017
@ramya-rao-a ramya-rao-a added this to the June 2017 milestone Jun 5, 2017
@ramya-rao-a ramya-rao-a added the emmet Emmet related issues label Jun 5, 2017
@ramya-rao-a
Copy link
Contributor

@sergeche Can we expect the extract-abbreviation module to validate abbreviations and catch the above mentioned error case?

This was referenced Jun 19, 2017
Closed
Closed
@ramya-rao-a ramya-rao-a added upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed upstream Issue identified as 'upstream' component related (exists outside of VS Code) insiders labels Jun 19, 2017
@ramya-rao-a
Copy link
Contributor

emmetio/atom-plugin#22 has been logged to move the validation upstream

@ramya-rao-a
Copy link
Contributor

screen shot 2017-06-18 at 11 29 35 pm

@ramya-rao-a
Copy link
Contributor

Fixed with microsoft/vscode-emmet-helper@cf60de5

as we want this fixed for current milestone and the upstream fix might take more time

@ramya-rao-a ramya-rao-a removed the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jun 26, 2017
@jrieken jrieken added the verified Verification succeeded label Jun 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Projects
None yet
Milestone
June 2017
Development

No branches or pull requests
3 participants
@jrieken @jens1o @ramya-rao-a