Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No blue icon on linux #28

Closed
aeschli opened this issue Nov 16, 2015 · 2 comments · Fixed by javifelices/vscode#3 · May be fixed by saurabharch/vscode#3 or chjkw/vscode#3
Closed

No blue icon on linux #28

aeschli opened this issue Nov 16, 2015 · 2 comments · Fixed by javifelices/vscode#3 · May be fixed by saurabharch/vscode#3 or chjkw/vscode#3
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
Nov 2015 - mid

Comments

@aeschli
Copy link
Contributor

aeschli commented Nov 16, 2015

I see the blue icon with 0.9 builds, but not with 0.10.1 builds.
Only a generic tool icon is shown.
@bpasero bpasero self-assigned this Nov 16, 2015
@bpasero bpasero added this to the 0.10.1 milestone Nov 16, 2015
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug Blocker labels Nov 16, 2015
@bpasero
Copy link
Member

bpasero commented Nov 16, 2015

I think the path is broken.

@bpasero
Copy link
Member

bpasero commented Nov 16, 2015

@joaomoreno can you help me out why the vscode.png ends up in the root of the zip instead of under the app folder? The fix is to put vscode.png under app/resources/linux in the same way how the welcome.md is already there.

The code to copy is:

es.merge(result, gulp.src(product.icons.application.png, { base: '.' }));

@bpasero bpasero assigned aeschli and unassigned bpasero Dec 15, 2015
@aeschli aeschli added the verified Verification succeeded label Dec 16, 2015
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@joaomoreno
fixes microsoft#28
0359743
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
Nov 2015 - mid
2 participants
@bpasero @aeschli