Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TS 2.4 Errors in rawSearchService.ts #28133

Closed
mjbvz opened this issue Jun 6, 2017 · 1 comment
Closed

Fix TS 2.4 Errors in rawSearchService.ts #28133

mjbvz opened this issue Jun 6, 2017 · 1 comment
Assignees
@roblourens
Labels
engineering VS Code - Build / issue tracking / etc.
Milestone
June 2017

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Jun 6, 2017

Errors
In rawSearchService.ts:

[11:23:14] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/node/rawSearchService.ts(58,7): Argument of type 'ISearchLog' is not assignable to parameter of type 'ISerializedSearchProgressItem'.
  Type 'ISearchLog' has no properties in common with type 'IProgress'.
[11:23:14] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/node/rawSearchService.ts(126,9): Argument of type 'IRawFileMatch | IProgress' is not assignable to parameter of type 'ISerializedSearchProgressItem'.
  Type 'IRawFileMatch' is not assignable to type 'ISerializedSearchProgressItem'.
    Type 'IRawFileMatch' has no properties in common with type 'IProgress'.
[11:23:14] Error: /Users/matb/projects/vscode/src/vs/workbench/services/search/node/rawSearchService.ts(149,9): Argument of type 'IRawFileMatch | IProgress' is not assignable to parameter of type 'IProgress'.
  Type 'IRawFileMatch' has no properties in common with type 'IProgress'.

How to investigate

  • Install TS 2.4 in the vscode workspace by running npm install typescript@next
  • Make sure vscode is using the workspace version of TS for error reporting by running the Select TypeScript versions command
@mjbvz mjbvz added the engineering VS Code - Build / issue tracking / etc. label Jun 6, 2017
@mjbvz mjbvz added this to the June 2017 milestone Jun 6, 2017
@roblourens
Copy link
Member

Those interfaces have become sort of a mess

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Milestone
June 2017
Development

No branches or pull requests
2 participants
@roblourens @mjbvz