Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a new keybinding context per quick open for quick navigate #28462

Closed
bpasero opened this issue Jun 11, 2017 · 1 comment
Closed

Introduce a new keybinding context per quick open for quick navigate #28462

bpasero opened this issue Jun 11, 2017 · 1 comment
Assignees
@bpasero
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
June 2017

Comments

@bpasero
Copy link
Member

bpasero commented Jun 11, 2017 •
edited

We have support to quick-navigate inside an opened quick open picker (e.g. Ctrl+Tab to quick navigate between editors of a group or Ctrl+Q for views). However, these actions are too generic, e.g. if you type Ctrl+Tab and quick open is visible it will just pick the next entry instead of jumping to the editor picker.

With introducing another context per quick open (e.g. inFilesPicker, inEditorsPicker) we can correctly support this scenario.
@bpasero bpasero added the debt Code quality issues label Jun 11, 2017
@bpasero bpasero added this to the June 2017 milestone Jun 11, 2017
@bpasero bpasero self-assigned this Jun 11, 2017
@bpasero bpasero changed the title Investigate quick-navigate issues with pickers Introduce a new keybinding context per quick open for quick navigate Jun 15, 2017
bpasero added a commit that referenced this issue Jun 15, 2017
@bpasero
Introduce a new keybinding context per quick open for quick navigate (f…
dc5cac4 
…ixes #28462)
@bpasero bpasero closed this as completed Jun 15, 2017
bpasero added a commit that referenced this issue Jun 15, 2017
@bpasero
Introduce a new keybinding context per quick open for quick navigate (f…
ce10822 
…ixes #28462) (#28784)
@bpasero bpasero mentioned this issue Jun 15, 2017
Closed
@bpasero bpasero added feature-request Request for new features or functionality verification-needed Verification of issue is requested and removed debt Code quality issues labels Jun 22, 2017
@bpasero
Copy link
Member Author

bpasero commented Jun 22, 2017

Verification
Verify that those pickers that have keybindings still work (e.g. file picker, commmands, view picker) and that you can always trigger one of the other pickers via keybindings even if another picker is currently opened (e.g. open commands and trigger the file picker keybinding).

Also verify our quick navigation pickers still work: Ctrl+Tab for editor navigation and Ctrl+Q for view navigation.

@isidorn isidorn added the verified Verification succeeded label Jun 28, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
June 2017
Development

No branches or pull requests
2 participants
@bpasero @isidorn