Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: Combine "Complete Emmet Abbreviation" and "Expand Emmet Abbreviation" #28556

Closed
tklepzig opened this issue Jun 12, 2017 · 8 comments
Closed

Improvement: Combine "Complete Emmet Abbreviation" and "Expand Emmet Abbreviation" #28556

tklepzig opened this issue Jun 12, 2017 · 8 comments
Assignees
@ramya-rao-a
Labels
emmet Emmet related issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
June 2017

Comments

@tklepzig
Copy link

tklepzig commented Jun 12, 2017 •
edited

  • VSCode Version: Code - Insiders 1.14.0-insider (4541e70, 2017-06-09T05:11:14.033Z)
  • OS Version: Linux x64 4.8.0-52-generic
  • Extensions: no extensions (I disabled all my extensions)
  • Settings:
{
    "window.zoomLevel": 1,
    "editor.fontSize": 14,
    "editor.tabCompletion": true,
    "editor.quickSuggestions": false,
    "git.autofetch": false
}

Steps to Reproduce:

  1. Create empty HTML file
  2. Write scr and trigger suggestions.
  3. You can now choose scriptfrom the list but you have to trigger the suggestion list once again to expand the script tag. Maybe it is possible to complete and expand the scr to <script></script> in one step?
@vscodebot vscodebot bot added the insiders label Jun 12, 2017
@tklepzig tklepzig mentioned this issue Jun 12, 2017
Closed
@ramya-rao-a ramya-rao-a added feature-request Request for new features or functionality emmet Emmet related issues labels Jun 12, 2017
@ramya-rao-a ramya-rao-a added this to the June 2017 milestone Jun 12, 2017
@ramya-rao-a ramya-rao-a self-assigned this Jun 12, 2017
ramya-rao-a added a commit that referenced this issue Jun 21, 2017
@ramya-rao-a
Refactoring to support #28556 eventually
8f5fc22
ramya-rao-a added a commit that referenced this issue Jun 21, 2017
@ramya-rao-a
Combine Expand/Complete Emmet abbreviations #28556
a318cab
@ramya-rao-a
Copy link
Contributor

@tklepzig This should be available in the next Insiders. Please give it a try

@ramya-rao-a ramya-rao-a mentioned this issue Jun 21, 2017
Closed
@tklepzig
Copy link
Author

@ramya-rao-a Thanks a lot. I'll try it and give you feedback.

@tklepzig
Copy link
Author

I tested it and it works as expected :)

@ramya-rao-a
Copy link
Contributor

Thanks @tklepzig !
I appreciate all the testing and feedback.

Please do try out other emmet actions and let me know if you see any other issues

@ramya-rao-a ramya-rao-a added the verification-needed Verification of issue is requested label Jun 26, 2017
@michelkaporin
Copy link
Contributor

michelkaporin commented Jun 28, 2017 •
edited

scr expands to <scr></scr> for me. Am I doing something wrong @ramya-rao-a ?

image

@ramya-rao-a
Copy link
Contributor

@michaelchiche When you choose the second suggestion you should get <script></script> instead of the previous script

@michelkaporin michelkaporin added the verified Verification succeeded label Jun 29, 2017
@michelkaporin
Copy link
Contributor

@ramya-rao-a thanks for clarification. Although I expected scr to expand to script (not sure if there really is an scr tag in HTML).

@ramya-rao-a
Copy link
Contributor

ya.. about that

emmet doesn't care if something is a valid tag. It just likes to expand stuff :)

That is a validation we might have to add on our end. I'll wait for more feedback and re-visit that later

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
emmet Emmet related issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
June 2017
Development

No branches or pull requests
3 participants
@michelkaporin @tklepzig @ramya-rao-a