Since yesterday's Insiders

Sandeep broke the split view I believe, I have the same behavior for explorer -> @sandy081

@isidorn I only see in Debug viewlet. Explorer is good for me

More strangely, out of sources, on same version of insiders, does not have this issue

@jrieken / @michelkaporin Anything to do with translations or nls?

I see the same as @sandy081 only for debug and only for insiders, not out of source
Translations is a good guess

@sandy081 translations are good, not sure about nls.

Debugged and found that following is returning undefined

nls.localize('variables', "Variables")

Not sure what caused this

FYI
@michelkaporin and @dbaeumer for translations
@alexandrudima for nls

@joaomoreno At build time, it is expected that all nls.localize calls are patched, that's why the method expects idx to be an integer and it doesn't use defaultValue.

From @sandy081 screenshot it appears that one specific nls.localize call, i.e. nls.localize('variables', "Variables') is not picked up, nor patched at build time. I'm not sure how old the screenshot is w.r.t. to master, but on master the file has 13 externalized strings, and in the screenshot the file has only 9.

The following are also not picked up:

• nls.localize('watch', "Watch")
• nls.localize('callStack', "Call Stack")
• nls.localize('breakpoints', "Breakpoints")

All four of them seem to share the same code pattern.

The nls patching was working on top of a quite old TypeScript language service (<2)... So when some new syntax came up (object spread), the patching failed to locate certain nls.localize calls. I'm actually surprised things worked thus far. I've updated it to use the same TypeScript version we depend on in the build tools.

@sandy081 Maybe we should build insiders for this?