Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge PeekViewWidget and ReferencesWidget #28726

Closed
jrieken opened this issue Jun 14, 2017 · 1 comment
Closed

Merge PeekViewWidget and ReferencesWidget #28726

jrieken opened this issue Jun 14, 2017 · 1 comment
Assignees
@jrieken
Labels
debt Code quality issues

Comments

@jrieken
Copy link
Member

jrieken commented Jun 14, 2017

There is unnecessary boilerplate code and abstraction for a single consumer of things
@jrieken jrieken self-assigned this Jun 14, 2017
@jrieken jrieken added the debt Code quality issues label Jun 14, 2017
@jrieken jrieken added this to the July 2017 milestone Jun 27, 2017
@jrieken jrieken modified the milestones: July 2017, August 2017 Jul 20, 2017
@jrieken jrieken modified the milestone: August 2017 Aug 17, 2017
jrieken added a commit that referenced this issue Sep 4, 2017
@jrieken
remove unused service, #28726
10e17ce
jrieken added a commit that referenced this issue Sep 4, 2017
@jrieken
move peek widget to begin with something, #28726
d218107
jrieken added a commit that referenced this issue Sep 4, 2017
@jrieken
update icon paths, #28726
9eff64d
@jrieken
Copy link
Member Author

jrieken commented Dec 15, 2017

won't happen...

@jrieken jrieken closed this as completed Dec 15, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
debt Code quality issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrieken