Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve "Extension Host Terminated" experience #28799

Closed
joaomoreno opened this issue Jun 15, 2017 · 2 comments
Closed

Improve "Extension Host Terminated" experience #28799

joaomoreno opened this issue Jun 15, 2017 · 2 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug extension-host Extension host issues freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues verified Verification succeeded
Milestone
June 2017

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Jun 15, 2017 •
edited

Here's how it looks like when the extension host crashes:

image

Issues:

  • There is no details about the crash, even though the extension host process likely tried to output data through its stdout and stderr
  • There is no guidance for the user to get more details about the error

There is no visible output because we eat up all the output from that extension host process and send it via process.send, in order to get structured, formatted output capabilities when extensions do console.log.
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug extension-host Extension host issues freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues labels Jun 15, 2017
@joaomoreno joaomoreno added this to the June 2017 milestone Jun 15, 2017
@joaomoreno joaomoreno self-assigned this Jun 15, 2017
@joaomoreno
Copy link
Member Author

I'm experimenting with enabling piped streams between the renderer and extension host process. I'd still leave the stdout and stderr patching done by bootstrap.js, in order to preserve the formatted output, but in case something else other than JS tries to write to those streams, we should catch that output and log it in our devtools. Here's what that looks like:

image

Now, all we gotta do it drive the user to open the devtools. 🎆

@joaomoreno
Copy link
Member Author

Not much info with the same error on Windows, but still better:

image

@roblourens roblourens added the verified Verification succeeded label Jun 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug extension-host Extension host issues freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues verified Verification succeeded
Projects
None yet
Milestone
June 2017
Development

No branches or pull requests
2 participants
@joaomoreno @roblourens