@SailorMax git is still an internal extension

Are you on stable VS Code or the Insiders?

Can you elaborate on your statement "it take 50% of all preinstalled extensions" ?

@ramya-rao-a Ok, with Git was wrong :) Then I just offer move Emmet from installation to VSCode marketplace

VSCode 1.13.1
Size of C:\Program Files (x86)\Microsoft VS Code\resources\app\extensions\ = 75MB, 5812 files
Size of C:\Program Files (x86)\Microsoft VS Code\resources\app\extensions\emmet\ = 37MB, 2221 files

When and if NodeJS will support zipped extensions, you can rejoin it again, but currently VSCode already contain too many files for "simple" editor and regular update process takes too many time already.

In this situation I think users, who require Emmet, can download it separately. All others will win 2000+ files and ~30% time of installation and updates (2000+ files is ~30% of total 7000 total files).

I'm in. It seems to me that something went wrong when building the new release of editor.

I'm install all dependencies from dependencies section of Emmet extension and I got:

 ~/Documents/OpenSource/test-emmet    fs node_modules/
3,3M	node_modules/

2M is a mocha module – see emmetio/expand-abbreviation#3.

Also I open \resources\app\extensions\emmet\node_modules on Windows and see that this directory includes typescript and other devDependencies.

Thanks for reporting this @SailorMax
Good catch @mrmlnc

I'll first look into the size issue (make a pass at all the dependencies soon and clear the node_modules up) and then circle back on this thread for the internal vs external extension discussion

Digging deeper, I found that even after fixing the upstream issue of emmetio/expand-abbreviation#3, the size problem will not be solved

Because this is a problem for all built-in extensions. i.e. dev dependecies are getting pulled into user's machine. Logged #29054 for the same.

Of the 40 something MB for emmet extension, 25MB was coming just from typescript.

Will see if we can have a general solution for this issue

With 6e366b8 the size of the emmet folder under extensions is reduced to 3.6 MB

and VS Code size is back to 184 MB

Also absorbed the change from emmetio/expand-abbreviation#3 with 9100807

This won't reduce the size of the emmet folder until #29054 is fixed though. But is a good cleanup nevertheless

@SailorMax @mrmlnc With size of emmet folder now down to a few MBs, I believe your initial concern about having emmet as internal extension is now taken care of.

At the moment, we will be going ahead with emmet as internal extension. We will revisit this decision when we make the new emmet model the default in the next iteration (or the one after that)

Thank you very much for reporting this issue though :)

@ramya-rao-a
I just want to emphasize, that core of my report was "2200+ files". 3.6MB in our century - is nothing. Today count of files is more important. Installations and updates of VSCode already is very slow. Few steps in same direction and VSCode setup time will be equal to Visual Studio setup time ;) This is wrong.

How many files did you reduce by your fixes?

@SailorMax Fixing #29054 reduced all the devdependencies as well. Now we (emmet) are down to 1.3 MB and about 200 files

Note to verifier:

• Check the size and # of files in the extensions\emmet folder of the installed VS Code Insiders.

@ramya-rao-a
VS Code Insider.zip looks much better :) Thanks!
But:

• Insider has node_modules/nsfw with "lodash/" = 1052 files - Is it normal?

• many extensions (git, html, json, markdown, merge-conflict, typescript) has similar node_modules: applicationinsights, vscode-extension-telemetry, vscode-jsonrpc (twice for css, html and json), vscode-languageclient, vscode-languageserver-types (twice for css, html and json), vscode-nls (twice for css, html and json), winreg. May be more.
  Can you try to reduce these also? We can save more 1000+ files and ~7MB!

Good point @SailorMax

@joaomoreno Thoughts?

Not addressing those issues any time soon.

cc @Tyriar @bpasero for nsfw

@Tyriar can we pick up NSFW from a commit or can we talk them into releasing a new version with your fix for that?

Yes I already pushed a PR to get the size of nsfw down Axosoft/nsfw#23, I didn't consider this a blocker to release though as it's only +5mb uncompressed. Made a comment asking for a patch release.