Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimap doesn't take editor.scrollBeyondLastLine into account and scrolls beyond the last line #28944

Closed
vvs opened this issue Jun 17, 2017 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-minimap Code/Text minimap widget issues verified Verification succeeded
Milestone

Comments

@vvs
Copy link

vvs commented Jun 17, 2017

  • VSCode Version: Code - Insiders 1.14.0-insider (73015a5, 2017-06-16T05:13:31.107Z)
  • OS Version: Windows_NT ia32 10.0.15063

Steps to Reproduce:

  1. Set "editor.scrollBeyondLastLine": false in settings.
    The editors now cannot scroll beyond the last line, as expected.

  2. Try to scroll via minimap, the minimap still scrolls beyond the last line, which looks weird and incorrect. The minimap preview shows that we are past the file content, but the actual editor shows that we are not past the last line.

Expected behavior:

Minimap should honor the editor settings w.r.t. scrolling past the last time. If editor cannot scroll past the last line, minimap should do the same. At the very minimum, if this sync is not desired for some reason, minimap settings should be introduced that disables scrolling past the last line, e.g. editor.minimap.scrollBeyondLastLine

@vscodebot vscodebot bot added the insiders label Jun 17, 2017
@ramya-rao-a ramya-rao-a added the editor-minimap Code/Text minimap widget issues label Jun 18, 2017
@alexdima
Copy link
Member

I can reproduce, but only in short files:

screen shot 2017-06-19 at 08 58 59

In long files (where the minimap itself needs to scroll), I believe this works as expected:
screen shot 2017-06-19 at 08 59 35

@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Jun 19, 2017
@alexdima alexdima added this to the On Deck milestone Jun 19, 2017
@vvs
Copy link
Author

vvs commented Jun 19, 2017

Indeed, the problem occurs when the minimap's content height is less then the height of the editor.

As soon as there is empty space in minimap (at the bottom), the problem occurs.

Thanks for looking into that!

@alexdima alexdima modified the milestones: June 2017, On Deck Jun 19, 2017
@michelkaporin michelkaporin added the verified Verification succeeded label Jun 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-minimap Code/Text minimap widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants