-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go to File does not find files in directory junctions #2896
Comments
Forgot to mention: Before January update this was working just fine (albeit really slowly) |
@NullScope is this on Windows or OSX? Can you provide steps how you setup the junctions? |
@bpasero This is on Windows. Here are the steps to reproduce the bug:
In my case the commands were: mklink /D "D:\Users\Bruno Ribeiro\Documents\JunctionFolder\FolderTwo" "C:\FolderTest\FolderTwo"
Now try to open a random file inside FolderOne using "Go to File" ( or Ctrl+P ) and Visual Code Studio will say there were no results found, however the sidemenu can navigate the files just fine.
Doing the exact same search using "Go to File" ( or Ctrl+P ) and Visual Code Studio will be able to find the file instantly. My project is much more complicated than this obviously as it works under an framework with a lot more child folders. But for git it has to be setup as the two top folders while my project is sitting as one of the many child folders inside those two folders. |
@NullScope excellent steps for me to verify. the issue is that since January release, quick open and full text search fail to work over links pointing to directories. @alexandrudima please verify on windows and mac/linux |
@bpasero Thank you! Glad to hear you are able to fix this issue! |
Verified search and ctrl+p in windows and linux with a "junction" folder. @bpasero If the code is different for mac than for linux, please also assign another person for verification. |
Should be good, thanks! |
If you have a parent folder with two directory junctions pointing somewhere else, "Go to File" ( or Ctrl+P ) will not be able to find the file you are looking for. However, if you put one of the directory junctions as your workspace folder "Go to File" will be able to find any existing file in the folder with no problem.
My current setup has two folders in two complete different locations and to edit them I have two junctions inside a folder with .git and .vscode. There doesn't seem to be an issue with other editors like Sublime Text 3
The text was updated successfully, but these errors were encountered: