Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to File does not find files in directory junctions #2896

Closed
NullScope opened this issue Feb 10, 2016 · 7 comments
Closed

Go to File does not find files in directory junctions #2896

NullScope opened this issue Feb 10, 2016 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Milestone

Comments

@NullScope
Copy link

If you have a parent folder with two directory junctions pointing somewhere else, "Go to File" ( or Ctrl+P ) will not be able to find the file you are looking for. However, if you put one of the directory junctions as your workspace folder "Go to File" will be able to find any existing file in the folder with no problem.

My current setup has two folders in two complete different locations and to edit them I have two junctions inside a folder with .git and .vscode. There doesn't seem to be an issue with other editors like Sublime Text 3

@NullScope
Copy link
Author

Forgot to mention: Before January update this was working just fine (albeit really slowly)

@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Feb 11, 2016
@bpasero
Copy link
Member

bpasero commented Feb 29, 2016

@NullScope is this on Windows or OSX? Can you provide steps how you setup the junctions?

@bpasero bpasero added this to the March 2016 milestone Feb 29, 2016
@NullScope
Copy link
Author

@bpasero This is on Windows.

Here are the steps to reproduce the bug:

  • Create one folder called FolderTest ( e.g C:/FolderTest )
  • Create two child folders called FolderOne and FolderTwo ( e.g C:/FolderTest/FolderOne & C:/FolderTest/FolderTwo )
  • Fill both folders with random files ( e.g C:/FolderTest/FolderOne/random.txt )
  • Create one folder somewhere else called JunctionFolder ( e.g Documents/JunctionFolder )
  • Use mklink in cmd with administrative rights and create two junctions inside the folder

In my case the commands were:
mklink /D "D:\Users\Bruno Ribeiro\Documents\JunctionFolder\FolderOne" "C:\FolderTest\FolderOne"

mklink /D "D:\Users\Bruno Ribeiro\Documents\JunctionFolder\FolderTwo" "C:\FolderTest\FolderTwo"

  • Now open a brand new window in Visual Studio Code without any project folders
  • Drag-in JunctionFolder into Visual Studio Code

Now try to open a random file inside FolderOne using "Go to File" ( or Ctrl+P ) and Visual Code Studio will say there were no results found, however the sidemenu can navigate the files just fine.

  • Now open again a brand new window
  • Drag-in JunctionFolder/FolderOne

Doing the exact same search using "Go to File" ( or Ctrl+P ) and Visual Code Studio will be able to find the file instantly.

My project is much more complicated than this obviously as it works under an framework with a lot more child folders. But for git it has to be setup as the two top folders while my project is sitting as one of the many child folders inside those two folders.

@bpasero bpasero closed this as completed in 3db6bb9 Mar 2, 2016
@bpasero bpasero added the important Issue identified as high-priority label Mar 2, 2016
@bpasero bpasero assigned alexdima and unassigned bpasero Mar 2, 2016
@bpasero
Copy link
Member

bpasero commented Mar 2, 2016

@NullScope excellent steps for me to verify. the issue is that since January release, quick open and full text search fail to work over links pointing to directories.

@alexandrudima please verify on windows and mac/linux

@NullScope
Copy link
Author

@bpasero Thank you! Glad to hear you are able to fix this issue!

@alexdima
Copy link
Member

Verified search and ctrl+p in windows and linux with a "junction" folder.

@bpasero If the code is different for mac than for linux, please also assign another person for verification.

@alexdima alexdima added the verified Verification succeeded label Mar 21, 2016
@bpasero
Copy link
Member

bpasero commented Mar 21, 2016

Should be good, thanks!

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants